Changing diagnostic severity from error to warning (microsoft#1387)

CTrando · web-flow · commit bede6cc266ae · 2019-07-25T15:05:07.000-07:00
diff --git a/src/Analysis/Ast/Impl/Analyzer/Evaluation/ExpressionEval.Generics.cs b/src/Analysis/Ast/Impl/Analyzer/Evaluation/ExpressionEval.Generics.cs
@@ -72,7 +72,7 @@ private bool GenericClassParameterValid(IReadOnlyList<IGenericTypeDefinition> ge
                     Resources.GenericNotAllTypeParameters,
                     GetLocation(expr).Span,
                     ErrorCodes.TypingGenericArguments,
-                    Severity.Error,
+                    Severity.Warning,
                     DiagnosticSource.Analysis));
                 return false;
             }
@@ -83,7 +83,7 @@ private bool GenericClassParameterValid(IReadOnlyList<IGenericTypeDefinition> ge
                    Resources.GenericNotAllUnique,
                    GetLocation(expr).Span,
                    ErrorCodes.TypingGenericArguments,
-                   Severity.Error,
+                   Severity.Warning,
                    DiagnosticSource.Analysis));
                 return false;
             }
diff --git a/src/Analysis/Ast/Impl/Analyzer/Symbols/ClassEvaluator.cs b/src/Analysis/Ast/Impl/Analyzer/Symbols/ClassEvaluator.cs
@@ -202,7 +202,7 @@ private void ReportInvalidBase(string argVal) {
                 Resources.InheritNonClass.FormatInvariant(argVal),
                 _classDef.NameExpression.GetLocation(Eval)?.Span ?? default,
                 Diagnostics.ErrorCodes.InheritNonClass,
-                Severity.Error,
+                Severity.Warning,
                 DiagnosticSource.Analysis
             ));
         }
diff --git a/src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs b/src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs
@@ -69,7 +69,7 @@ private static bool TypeVarArgumentsValid(IArgumentSet argSet) {
                     new DiagnosticsEntry(Resources.TypeVarSingleConstraint,
                         callLocation?.Span ?? default,
                         Diagnostics.ErrorCodes.TypingTypeVarArguments,
-                        Severity.Error, DiagnosticSource.Analysis)
+                        Severity.Warning, DiagnosticSource.Analysis)
                 );
                 return false;
             }
diff --git a/src/Analysis/Ast/Impl/Specializations/Typing/TypingModule.cs b/src/Analysis/Ast/Impl/Specializations/Typing/TypingModule.cs
@@ -244,7 +244,7 @@ private IPythonType CreateTypeAlias(IArgumentSet args) {
                     new DiagnosticsEntry(Resources.NewTypeFirstArgNotString.FormatInvariant(firstArgType), 
                         expression?.GetLocation(eval)?.Span ?? default, 
                         Diagnostics.ErrorCodes.TypingNewTypeArguments,
-                        Severity.Error, DiagnosticSource.Analysis)
+                        Severity.Warning, DiagnosticSource.Analysis)
                 );
             }
             // TODO: report wrong number of arguments
diff --git a/src/Analysis/Ast/Test/LintNoQATests.cs b/src/Analysis/Ast/Test/LintNoQATests.cs
@@ -90,7 +90,7 @@ public async Task VarNamedNoQAStillGivesDiagnostic() {
             diagnostic.Message.Should().Be(Resources.GenericNotAllUnique);
             diagnostic.ErrorCode.Should().Be(ErrorCodes.TypingGenericArguments);
             diagnostic.SourceSpan.Should().Be(8, 8, 8, 21);
-            diagnostic.Severity.Should().Be(Severity.Error);
+            diagnostic.Severity.Should().Be(Severity.Warning);
         }
 
         [DataRow("x = y #noqa")]

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ private void ReportInvalidBase(string argVal) {`
`202`	`202`	`Resources.InheritNonClass.FormatInvariant(argVal),`
`203`	`203`	`_classDef.NameExpression.GetLocation(Eval)?.Span ?? default,`
`204`	`204`	`Diagnostics.ErrorCodes.InheritNonClass,`
`205`		`- Severity.Error,`
	`205`	`+ Severity.Warning,`
`206`	`206`	`DiagnosticSource.Analysis`
`207`	`207`	`));`
`208`	`208`	`}`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ private static bool TypeVarArgumentsValid(IArgumentSet argSet) {`
`69`	`69`	`new DiagnosticsEntry(Resources.TypeVarSingleConstraint,`
`70`	`70`	`callLocation?.Span ?? default,`
`71`	`71`	`Diagnostics.ErrorCodes.TypingTypeVarArguments,`
`72`		`- Severity.Error, DiagnosticSource.Analysis)`
	`72`	`+ Severity.Warning, DiagnosticSource.Analysis)`
`73`	`73`	`);`
`74`	`74`	`return false;`
`75`	`75`	`}`
Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ private IPythonType CreateTypeAlias(IArgumentSet args) {`
`244`	`244`	`new DiagnosticsEntry(Resources.NewTypeFirstArgNotString.FormatInvariant(firstArgType),`
`245`	`245`	`expression?.GetLocation(eval)?.Span ?? default,`
`246`	`246`	`Diagnostics.ErrorCodes.TypingNewTypeArguments,`
`247`		`- Severity.Error, DiagnosticSource.Analysis)`
	`247`	`+ Severity.Warning, DiagnosticSource.Analysis)`
`248`	`248`	`);`
`249`	`249`	`}`
`250`	`250`	`// TODO: report wrong number of arguments`
Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ public async Task VarNamedNoQAStillGivesDiagnostic() {`
`90`	`90`	`diagnostic.Message.Should().Be(Resources.GenericNotAllUnique);`
`91`	`91`	`diagnostic.ErrorCode.Should().Be(ErrorCodes.TypingGenericArguments);`
`92`	`92`	`diagnostic.SourceSpan.Should().Be(8, 8, 8, 21);`
`93`		`- diagnostic.Severity.Should().Be(Severity.Error);`
	`93`	`+ diagnostic.Severity.Should().Be(Severity.Warning);`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`[DataRow("x = y #noqa")]`