Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, when it has all its change sets, will restructure the Jython 3 code into a Java module
core
. The objective is to control visibility of objects that will become API, while allowing us to use package structure internally to the project. (Without Java modularity, everything we make public for re-use between packages internally, becomes public externally.)It is intended that there be more than one module eventually, but always a small number.
We are applying some off-repo learning (in VSJ4). The first step (adding module definitions) does not achieve the objective: public classes must be allocated to packages that are either exported or not, and in some cases a class must be divided between them. The off-repo work also advanced the functional state of the implementation so we shall bring that in too.
This gets quite difficult so the PR will be draft for a while.