Open
Description
I need to add tests for the KafkaAdmin changes I made:
- Stop using broker-errors for client-side problems dpkp/kafka-python#1639
- Fix KafkaAdmin send to controller dpkp/kafka-python#1640
- Add group coordinator lookup dpkp/kafka-python#1641
- Fix describe groups dpkp/kafka-python#1642
- Add list consumer groups offsets dpkp/kafka-python#1643
- Set a clear default value for
validate_only
/include_synonyms
dpkp/kafka-python#1645
I didn't have time yet to do tests... Given that the existing KafkaAdminClient
code currently on the master branch is broken, sometimes in subtle ways, I decided fine to put them up as-is since then the code will be mostly working, and then later add tests to prevent regressions.
Frankly, the test fixtures are a bit of a mess, so I will probably instead go the route of finishing dpkp#1193, as that will both simplify the code drastically and require a few fixture changes.
And then after that tackle the tests/missing coverage.
But creating this and assigning it to myself so that I don't forget
Metadata
Metadata
Assignees
Labels
No labels