Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 20102d6

Browse files
committed
Merge pull request plotly#363 from plotly/fix-offline-enterprise-url
🐛 get the correct plotly_domain, not the "session"'s
2 parents bb29e74 + 5bebbd2 commit 20102d6

File tree

3 files changed

+27
-5
lines changed

3 files changed

+27
-5
lines changed

CHANGELOG.md

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,29 @@ This project adheres to [Semantic Versioning](http://semver.org/).
44

55
## [Unreleased]
66

7+
## [1.9.2] - 2015-11-30
8+
**Bug Fix**: Previously, the "Export to plot.ly" link on
9+
offline charts would export your figures to the
10+
public plotly cloud, even if your `config_file`
11+
(set with `plotly.tools.set_config_file` to the file
12+
`~/.plotly/.config`) set `plotly_domain` to a plotly enterprise
13+
URL like `https://plotly.acme.com`.
14+
15+
This is now fixed. Your graphs will be exported to your
16+
`plotly_domain` if it is set.
17+
718
## [1.9.1] - 2015-11-26
819
### Added
9-
- The FigureFactory can now create annotated heatmaps with `.create_annotated_heatmap`.
20+
- The FigureFactory can now create annotated heatmaps with `.create_annotated_heatmap`. Check it out with:
21+
```
22+
import plotly.tools as tls
23+
help(tls.FigureFactory.create_annotated_heatmap)
24+
```
1025
- The FigureFactory can now create tables with `.create_table`.
26+
```
27+
import plotly.tools as tls
28+
help(tls.FigureFactory.create_table)
29+
```
1130

1231
## [1.9.0] - 2015-11-15
1332
- Previously, using plotly offline required a paid license.

plotly/offline/offline.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
import warnings
1212
from pkg_resources import resource_string
1313

14-
from plotly import session, tools, utils
14+
import plotly
15+
from plotly import tools, utils
1516
from plotly.exceptions import PlotlyError
1617

1718

@@ -129,8 +130,10 @@ def iplot(figure_or_data, show_link=True, link_text='Export to plot.ly',
129130
config['linkText'] = link_text
130131
jconfig = json.dumps(config)
131132

132-
plotly_platform_url = session.get_session_config().get('plotly_domain',
133-
'https://plot.ly')
133+
# TODO: The get_config 'source of truth' should
134+
# really be somewhere other than plotly.plotly
135+
plotly_platform_url = plotly.plotly.get_config().get('plotly_domain',
136+
'https://plot.ly')
134137
if (plotly_platform_url != 'https://plot.ly' and
135138
link_text == 'Export to plot.ly'):
136139

plotly/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '1.9.1'
1+
__version__ = '1.9.2'

0 commit comments

Comments
 (0)