feat(ngModel) support ngNoTrim attribute

grevory · mhevery · commit c9030805aae1 · 2012-09-05T09:30:41.000-07:00
diff --git a/src/ng/directive/input.js b/src/ng/directive/input.js
@@ -25,6 +25,8 @@ var inputType = {
    *    patterns defined as scope expressions.
    * @param {string=} ngChange Angular expression to be executed when input changes due to user
    *    interaction with the input element.
+   * @param {boolean=} ngNoTrim Prevents Angular from automatically trimming the value to contain no 
+   *    extra white space
    *
    * @example
       <doc:example>
@@ -37,7 +39,7 @@ var inputType = {
          </script>
          <form name="myForm" ng-controller="Ctrl">
            Single word: <input type="text" name="input" ng-model="text"
-                               ng-pattern="word" required>
+                               ng-pattern="word" required ng-no-trim>
            <span class="error" ng-show="myForm.input.$error.required">
              Required!</span>
            <span class="error" ng-show="myForm.input.$error.pattern">
@@ -66,6 +68,12 @@ var inputType = {
             input('text').enter('hello world');
             expect(binding('myForm.input.$valid')).toEqual('false');
           });
+
+          it('should not be trimmed', function() {
+            input('text').enter('untrimmed ');
+            expect(binding('text')).toEqual('untrimmed ');
+            expect(binding('myForm.input.$valid')).toEqual('true');
+          });
         </doc:scenario>
       </doc:example>
    */
@@ -370,7 +378,15 @@ function isEmpty(value) {
 function textInputType(scope, element, attr, ctrl, $sniffer, $browser) {
 
   var listener = function() {
-    var value = trim(element.val());
+    var value = element.val();
+
+    // By default we will trim the value
+    // If the attribute ng-no-trim exists we will avoid trimming
+    // e.g. <input ng-model="foo" ng-no-trim>
+    if (isUndefined(attr.ngNoTrim)) {
+      var value = trim(value);
+    }
+    
 
     if (ctrl.$viewValue !== value) {
       scope.$apply(function() {
diff --git a/test/ng/directive/inputSpec.js b/test/ng/directive/inputSpec.js
@@ -382,6 +382,14 @@ describe('input', function() {
   });
 
 
+  it('should update the model and not trim the value', function() {
+    compileInput('<input type="text" ng-model="name" name="alias" ng-no-trim/>');
+
+    changeInputValueTo('  a  ');
+    expect(scope.name).toEqual('  a  ');
+  });
+
+
   it('should allow complex reference binding', function() {
     compileInput('<input type="text" ng-model="obj[\'abc\'].name"/>');
 
