remove unused and duplicated code #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common_chat_templates_init is already done at end of load_model in server.hpp
kherud
reviewed
Jun 20, 2025
|
Hey @arnej27959 thanks for the PR! Looks good to me (apart from the comment), thanks for pointing out the unused code. The original goal of the Java binding was to stay as close as possible to the llama.cpp server code, to better keep up with its fast development. It mostly replaces the HTTP stuff with JNI (+ some extras like logging). I didn't have a look at the llama.cpp code base in a while to judge if that's still the best idea. Earlier we passed the model parameters as a json to llama.cpp, but then switched to re-using the C++ CLI arg parsing code. I think most of what you removed are remains of the old json code, so it's alright to remove it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have investigated upgrading to newer llama.cpp, but to simplify the work it would be helpful to get these changes in first; they should have no effect on current behavior.
Thanks in advance,
-arnej (from vespa.ai)