Fix generating diff for shouldBeEqual (#5065)

wojcikt · web-flow · commit 4671562a0c82 · 2025-09-05T22:31:16.000Z
diff --git a/kotest-assertions/kotest-assertions-core/src/commonMain/kotlin/io/kotest/matchers/equals/shouldEqual.kt b/kotest-assertions/kotest-assertions-core/src/commonMain/kotlin/io/kotest/matchers/equals/shouldEqual.kt
@@ -23,7 +23,7 @@ fun <A> beEqual(expected: A): Matcher<A> = object : Matcher<A> {
    override fun test(value: A) = ComparisonMatcherResult(
       passed = value == expected,
       expected = expected.print(),
-      actual = expected.print(),
+      actual = value.print(),
       failureMessageFn = { "$value should be equal to $expected" },
       negatedFailureMessageFn = { "$value should not be equal to $expected" })
 }
diff --git a/kotest-assertions/kotest-assertions-core/src/jvmTest/kotlin/com/sksamuel/kotest/equals/ShouldBeEqualTest.kt b/kotest-assertions/kotest-assertions-core/src/jvmTest/kotlin/com/sksamuel/kotest/equals/ShouldBeEqualTest.kt
@@ -31,7 +31,7 @@ class ShouldBeEqualTest : FunSpec() {
          val listA = listOf(1, 2, 3, 4)
          val listB = listOf(1, 2, 3)
          shouldThrow<AssertionError> { listA shouldBeEqual listB }.message shouldBe """[1, 2, 3, 4] should be equal to [1, 2, 3]
-expected:<[1, 2, 3]> but was:<[1, 2, 3]>"""
+expected:<[1, 2, 3]> but was:<[1, 2, 3, 4]>"""
       }
    }
 }

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ fun <A> beEqual(expected: A): Matcher<A> = object : Matcher<A> {`
`23`	`23`	`override fun test(value: A) = ComparisonMatcherResult(`
`24`	`24`	`passed = value == expected,`
`25`	`25`	`expected = expected.print(),`
`26`		`- actual = expected.print(),`
	`26`	`+ actual = value.print(),`
`27`	`27`	`failureMessageFn = { "$value should be equal to $expected" },`
`28`	`28`	`negatedFailureMessageFn = { "$value should not be equal to $expected" })`
`29`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class ShouldBeEqualTest : FunSpec() {`
`31`	`31`	`val listA = listOf(1, 2, 3, 4)`
`32`	`32`	`val listB = listOf(1, 2, 3)`
`33`	`33`	`shouldThrow<AssertionError> { listA shouldBeEqual listB }.message shouldBe """[1, 2, 3, 4] should be equal to [1, 2, 3]`
`34`		`-expected:<[1, 2, 3]> but was:<[1, 2, 3]>"""`
	`34`	`+expected:<[1, 2, 3]> but was:<[1, 2, 3, 4]>"""`
`35`	`35`	`}`
`36`	`36`	`}`
`37`	`37`	`}`