Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 4990758

Browse files
committed
Test more PHP and Symfony versions on Travis
1 parent e1adacf commit 4990758

2 files changed

Lines changed: 13 additions & 9 deletions

File tree

.travis.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,18 @@ env:
2121
matrix:
2222
fast_finish: true
2323
include:
24-
# jobs are ordered in a specific way to get Travis results faster (first
25-
# execute the fastest jobs, then the slowest and finally the jobs that can fail)
26-
- php: 7.0
27-
env: SYMFONY_VERSION="3.0.*"
24+
- php: nightly
25+
env: SYMFONY_VERSION="dev-master"
26+
- php: 7.1
27+
env:
28+
- SYMFONY_VERSION="3.2.*"
29+
- CHECK_PHP_SYNTAX="yes"
2830
- php: 7.0
2931
env: SYMFONY_VERSION="3.1.*"
3032
- php: 5.6
3133
env: SYMFONY_VERSION="2.3.*"
3234
- php: 5.6
33-
env:
34-
- SYMFONY_VERSION="2.7.*"
35-
- CHECK_PHP_SYNTAX="yes"
35+
env: SYMFONY_VERSION="2.7.*"
3636
- php: 5.6
3737
env:
3838
- SYMFONY_VERSION="2.8.*"
@@ -49,6 +49,7 @@ matrix:
4949
- php: 5.6
5050
env: TWIG_VERSION="2.x-dev"
5151
allow_failures:
52+
- php: nightly
5253
- php: hhvm-stable
5354
- env: TWIG_VERSION="2.x-dev"
5455
- env:
@@ -62,7 +63,7 @@ before_install:
6263
- echo session.gc_probability = 0 >> $INI_FILE
6364
- echo opcache.enable_cli = 1 >> $INI_FILE
6465
- if [[ "SYMFONY_VERSION" == "2.8.*" || "SYMFONY_VERSION" == 3.* ]]; then export SYMFONY_DEPRECATIONS_HELPER="strict"; fi;
65-
- if [[ "$ENABLE_CODE_COVERAGE" != "true" && "$TRAVIS_PHP_VERSION" != hhvm* ]]; then phpenv config-rm xdebug.ini; fi;
66+
- if [[ "$ENABLE_CODE_COVERAGE" != "true" ]]; then rm -f ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/xdebug.ini; fi;
6667
- composer selfupdate
6768
- if [[ "$SYMFONY_VERSION" != "" ]]; then composer require "symfony/symfony:${SYMFONY_VERSION}" --no-update; fi;
6869
- if [[ "$TWIG_VERSION" != "" ]]; then composer require "twig/twig:${TWIG_VERSION}" --no-update; fi;

Tests/Controller/CustomMenuTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
namespace JavierEguiluz\Bundle\EasyAdminBundle\Tests\Controller;
1313

1414
use JavierEguiluz\Bundle\EasyAdminBundle\Tests\Fixtures\AbstractTestCase;
15+
use Symfony\Component\HttpKernel\Kernel;
1516

1617
class CustomMenuTest extends AbstractTestCase
1718
{
@@ -194,8 +195,10 @@ public function testExternalRoutesDontIncludeIndexParameters()
194195
{
195196
$crawler = $this->getBackendHomepage();
196197

198+
// Starting from Symfony 3.2, routes are generated using the PHP_QUERY_RFC3986 option
199+
$queryStringParameter = Kernel::VERSION_ID >= 30200 ? 'Lorem%20Ipsum' : 'Lorem+Ipsum';
197200
$this->assertSame(
198-
'/custom-route?custom_parameter=Lorem+Ipsum',
201+
'/custom-route?custom_parameter='.$queryStringParameter,
199202
$crawler->filter('.sidebar-menu li:contains("Custom External Route") a')->attr('href')
200203
);
201204

0 commit comments

Comments
 (0)