Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Follow pattern for monochromatic systray icon #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabianski7 opened this issue Jun 18, 2020 · 33 comments
Closed

Follow pattern for monochromatic systray icon #352

fabianski7 opened this issue Jun 18, 2020 · 33 comments

Comments

@fabianski7
Copy link
Contributor

104127-18-06-2020
in dark themes, the ksnip icon does not follow the pattern of the others

@DamirPorobic
Copy link
Member

Whats the expectation here? We have only one ksnip icon. For other icons we have dark and light versions but for the application icon there is only one. Maybe someone needs to design a light version?

@fabianski7
Copy link
Contributor Author

Yes. A monochromatic version just like the other icons in the photo I sent.

Maybe someone needs to design a light version?

So, let's just wait for some designer to do that job. ^_^

Thanks

@DamirPorobic
Copy link
Member

The only designer working on the project is me and I'm not a designer 🤣
Maybe someone provides a PR, lets see.

@fabianski7
Copy link
Contributor Author

Hey,

Here are the icons

All credits are from user @Manueljlin and @noahdvs of the @vdgmainroom group on telegram.

Screenshot_20200618_112807

<svg viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg">
  <defs id="defs3051">
    <style type="text/css" id="current-color-scheme">
      .ColorScheme-Text {
        color:#eff0f1;
      }
      </style>
  </defs>
  <path
      style="fill:currentColor;fill-opacity:1;stroke:none" 
      d="m3 2 1 1v10l-1 1h4v-5h3v5h3v-3l-2.537109-2.5371094 2.537109-2.3925781v-4.0703125l-6 5.5v-5.5z"
      class="ColorScheme-Text"
  />
  <path
      style="fill:currentColor;fill-opacity:1;stroke:none" 
      d="m6 8.4453125v-.0273437l-.0136719.0117187z" fill="#c60000" opacity=".272405"
      class="ColorScheme-Text"
  />
</svg>
<svg viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg">
  <defs id="defs3051">
    <style type="text/css" id="current-color-scheme">
      .ColorScheme-Text {
        color:#232629;
      }
      </style>
  </defs>
  <path
      style="fill:currentColor;fill-opacity:1;stroke:none" 
      d="m3 2 1 1v10l-1 1h4v-5h3v5h3v-3l-2.537109-2.5371094 2.537109-2.3925781v-4.0703125l-6 5.5v-5.5z"
      class="ColorScheme-Text"
  />
  <path
      style="fill:currentColor;fill-opacity:1;stroke:none" 
      d="m6 8.4453125v-.0273437l-.0136719.0117187z" fill="#c60000" opacity=".272405"
      class="ColorScheme-Text"
  />
</svg> 

@DamirPorobic
Copy link
Member

Good start, but I would prefer something mosaic like we have it currently. Maybe same mosaic but replacing the colors with lighter and darker white or gray colors?

@noahadvs
Copy link

Good start, but I would prefer something mosaic like we have it currently. Maybe same mosaic but replacing the colors with lighter and darker white or gray colors?

I don't think that'll work very well at small icon sizes. It might barely pass at 22x22.

@noahadvs
Copy link

Not sure why, but every time I try to upload a picture of an icon, GitHub makes it look blurry as hell.

@DamirPorobic
Copy link
Member

DamirPorobic commented Jun 19, 2020

Don't know, maybe something like this
image

I don't think that'll work very well at small icon sizes. It might barely pass at 22x22.

You might be right, maybe we need an overall new icon. The one we have now was designed by me as you probably can guess. And I agree, on the taskbar it looks like a dab of paint.

@noahadvs
Copy link

🙄 and of course GitHub doesn't let me upload SVGs either.

This one is 16x16, based on what was in the archive file posted above.
ksnip16.tar.gz

@DamirPorobic
Copy link
Member

Make a screenshot with ksnip and copy paste it here?

@noahadvs
Copy link

Like I said, github makes it look blurry as hell for some reason:
Screenshot_20200619_101811

@noahadvs
Copy link

noahadvs commented Jun 19, 2020

When you actually open up the SVG, it's as crisp as you can possibly get it. Or open the picture in another tab.

@DamirPorobic
Copy link
Member

Actually doesn't look blurry to me.

@noahadvs
Copy link

Oh silly me. It's because my browser is zoomed in to 110%

@noahadvs
Copy link

Note: I forgot to redo the stylesheets for the SVG I posted, so that icon isn't 100% ready to be used and Plasma's system tray actually uses 22x22 icons by default. I'm currently a bit busy with other projects, so I can't spend a lot of time on this, but there are some instructions for optimizing icons and adding stylesheets so that the icon can match the user's color scheme:

https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips
http://notmart.org/blog/2016/05/icon-colors/

@ghost
Copy link

ghost commented Sep 11, 2020

Newbie slightly confused, filtered on Open Issues and there is a closed button showing but it allows entering comment. If still open here is screenshot or disregard.

Panel

@DamirPorobic
Copy link
Member

If you mean this button
image

This only means that issue #381 was closed.

I'm not sure if I get what your screenshot is showing? Is this an icon drawn by you?

@ghost
Copy link

ghost commented Sep 11, 2020

Thank you for the explanation. Screenshot is Ubuntu Mate panel at 28 px. Reworked your .svg icon and added launcher using it next to ksnip launcher with your icon. Apologize for not explaining it. New screenshot is same but changed panel size to 16 px.
p

@ghost
Copy link

ghost commented Sep 11, 2020

Here is image as in Inkscape
p2

@DamirPorobic
Copy link
Member

Thanks, how does it look with spaces filled? Do we need the background or can we keep it transparent for mono?

@ghost
Copy link

ghost commented Sep 11, 2020

Two screenshots 1 of images in Inkscape and other of Panel @ 28 px. Last two in panel are transparent background.

@ghost
Copy link

ghost commented Sep 11, 2020

Oops accidentally hit comment, here are the images
Example 2
Examples

@ghost
Copy link

ghost commented Sep 12, 2020

DamirPorobic Thanks, how does it look with spaces filled? Do we need the background or can we keep it transparent for mono?

Yes below are some images. Works easier if you don't mind slightly rounded corners that don't show in sizes used. Easy to change fill, transparency, stroke width (am using Inkscape). Black is representing transparent and Error Example shows reason for Round join versu Miter join which then makes changing stroke width a breeze.

Ksnip Icon Examples
Ksnip Method
Ksnip Stroke Examples

@DamirPorobic
Copy link
Member

Thanks for providing so many examples, it looks like you invested a lot of time, interesting to see some alternatives. I don't mind the rounded corners, seems good to me. I don't like the thick stroke, the thinner look nicer for me. Mono Gray Transparent and mono colored transparent look nice, I think does are my favorites currently. What we could also try is instead of filled with gray or color, trying to fill white. Other application icons in mono seem to be also made just of one color, how would that look.

@ghost
Copy link

ghost commented Sep 14, 2020

Ok some more examples and instructions (Apologize for not using Ksnip in all images :-) )
Black simulates checkerboard background for better viewing
You can create multiple versions, create screenshot and follow below, then pick ones you like and then from Inkscape export as .png either with colored background or transparent background by setting square fill to None. Been fun actually ended up redoing 9 other icons to look better in panel. One in dark theme was almost black. See same in Themes where not all variants work properly. Hard to please everybody.

Stroke

K One Color

Monochrome Instructions

New Examples

New Examples Instructions

@noahadvs
Copy link

noahadvs commented Sep 14, 2020

If you're making images that are meant to be viewed on a screen, don't use real world units of measurement. Always use px and make sure you're creating the icon for the size it's meant to be viewed at (or an integer multiple of that size since we can use SVGs). If you want an icon for a systray that uses 16x16px icons, make a 16x16px version and likewise for 22xx22px and 28x28px. When you make strokes that are vertical, horizontal or diagonal with a 45 degree angle, be sure that the nodes of the stroke are aligned to the centers of pixels if using an odd stroke width or between pixels if using an even stroke width to avoid making them blurry.

@DamirPorobic
Copy link
Member

Thanks @noahadvs for the tips. We are definitely going to use SVGs in the final form for the application but what @Mendy12 is currently providing is totally fine for now.

I think I favor currently those two:
image

What do you guys think?

@ghost
Copy link

ghost commented Sep 14, 2020

I'm back. Took note of @noahadvs. My problem is didn't understand systray distinction. Using MATE and different sizes showed up fine in my panels. Has Indicator Applet Complete and when I told VLC Player to place icon in system tray it showed up there. When I changed panels to 16 icons looked ok but systray were small while icons in panels were still fine. Wouldn't know how to test. But I did rework them and in deference to @noahadvs (I only use inch, not mm or px.) on screen determined that stroke limits would be limited to between 0.320px and 1.020px for the stroke width. Do not have a way to test as actual system tray icon but can provide some sample pngs if you wish or you can modify your base svg using above procedures on the 450px icon and applying the strokes within the limits and then resize down to 16px. Note gray is arbitrarily set to 30% which can be changed in each triangle.

Redone

@ghost
Copy link

ghost commented Sep 14, 2020

Here are 5 icons at 16px transparent. 1 Solid, rest are Color Filled with strokes of .32px, 52px, 72px, and 102px in that order. The screenshot is with my panel at 16px and when I open it the image without zoom looks like other icons in panel but larger than what shows in my systray. Does program take the svg and then resize from there or does OS handle that? Not a programmer or designer. Zoomed smaller looks like solid and colored .72 look best. Would taking the current ksnip.svg, apply the different stroke one at a time and recompile elsewhere work? Then seems like you would either have a colored icon or a solid icon but not both.
S32

S32

C32

C52

C72

C102

Redone 16px on 16px panel

@ghost
Copy link

ghost commented Sep 14, 2020

Resubmiting icon pngs think messed up. Solid 32 is there solid white on zero fill background.

Solid 32
S32
Colored 32
C32
Colored 52
C52
Colored 72
C72
Colored 102
C102

@ghost
Copy link

ghost commented Sep 15, 2020

Thanks to Damir and noahadvs. Been playing for awhile and better understand. On image of panel the clock icon does switch from black shade in white panel and white shaded if I switch to a theme with dark panel. On my system icon is at /usr/share/icons/mate/scalable/status/file-name.svg. Opening it is 13x15 px composed of paths with colors RGB 190. ksnip icon doesn't seem to scale past a certain point but am using appimage so system may not be aware. (was looking in source icons folder and is ksnip.icns the scaleable icon when installed in system vs appimage? Checked multiple status icons and they seem to follow with RGB 190 color (probably better looking than pure white?) and in case of attached image they change the color of arcs by reducing the opacity. (Note tried it but doesn't work due to overlaping of triangles) But it doesn't show unless I change icons used in my chosen theme. With icon set I use it shows a speaker in place of below image. The two k's were done in Inkscape using ksnip.svg from source. Page size 16x16px, background for visibility RGB 80, stroke and fill colors solid RGB190 Join:Round join, stroke .052px. For colored same, just stroke color to RGB190. Group size to 15x15px, center to page and ungroup, save as desired. This is if you have a way to test the finished icon in program somehow. I don't have that knowledge.

Theme TraditionaOK

Status Color

Two Versions

@DamirPorobic DamirPorobic self-assigned this Nov 9, 2020
@DamirPorobic DamirPorobic changed the title Monochromatic systray icon Add support for monochromatic systray icon Nov 9, 2020
@DamirPorobic DamirPorobic changed the title Add support for monochromatic systray icon Follow pattern for monochromatic systray icon Nov 9, 2020
@DamirPorobic
Copy link
Member

Done, you should see now an icon that follows the mono pattern.

@fabianski7
Copy link
Contributor Author

54
😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants