@LyzardKing FYI

This also requires changing the dbus?

I think it's the same issue as #390

Ok, let's move those two to 1.8.0

@LyzardKing Do you know how to detect if we are running Wayland or X11 under Snap? Usually we echo XDG_SESSION_TYPE and this variable either contains x11 or wayland string. Works outside a Snap but not inside. It looks like with snap we fail to detect that we are running wayland and try to use X11 ImageGrabber which results in a crash.

I get those strings if I echo XDG_SESSION_TYPE in the snap environment
To test it you can run snap run --shell ksnip and that'll open a bash shell in the snap env

Thanks, will try that.

@LyzardKing Any change we can make the old API work with Snap or is our only chance here the new API?

As discussed in #390 I opened a PR with the removal of the hardcoded unity desktop.
It was necessary to show the appindicator, but now it seems to work fine without.

The old API cannot work in the snap because we cannot access /tmp.
And that is not overridable.
The only way to make this work is to use the new API.
Another possibility (but I don't think it's possible) would be to tell gnome to save the screenshots in another tmp folder.
The snap has it's own tmp folder in /tmp/snap.ksnip/tmp.

Or the snap could be made not confined (classic).
In that case it would have full access to the system.

Another possibility (but I don't think it's possible) would be to tell gnome to save the screenshots in another tmp folder.

This is actually possible, let's keep that as a backup option if the new API doesn't work out

If I set the call to the wayland grabber as:

QDBusInterface interface(QStringLiteral("org.freedesktop.portal.Desktop"), QStringLiteral("/org/freedesktop/portal/desktop"), QStringLiteral("org.freedesktop.portal.Screenshot"));

and pull you commit to use the general screenshot in the snap
I get this error:

Invalid reply from DBus: Type of message, “(ss)”, does not match expected type “(sa{sv})”

Yes, I got that far too. I need to figure out next with what parameters the screenshot methods needs to be called with. For testing just passed some strings there which seem to be wrong.

Fixed with #243 we use now the generic wayland portal for taking screenshots under snap.