Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add option to select the default action for tray icon left click #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erenseymen opened this issue Dec 13, 2020 · 7 comments
Closed

Add option to select the default action for tray icon left click #502

erenseymen opened this issue Dec 13, 2020 · 7 comments
Assignees
@fnkabit
Labels
feature_request

Comments

@erenseymen
Copy link

erenseymen commented Dec 13, 2020 •
edited
Loading

For example, in Flameshot, the default action for tray icon left click is selecting rectangular area, which is quite convenient. Other people may want to select full screen or other actions as default action as well.

P.S.: Thanks for ksnip and the new features in v1.8.
@DamirPorobic
Copy link
Member

I like the idea of configurable default action for tray icon left click.

@fnkabit
Copy link
Contributor

fnkabit commented Dec 17, 2020 •
edited
Loading

@DamirPorobic If I understand this properly, instead of the 'Show Editor' action, the action performed when left-clicking would be configurable to 'Show Editor', 'Rectangular Area', 'Last Rectangular Area', etc.
Is this correct ?

@erenseymen
Copy link
Author

erenseymen commented Dec 17, 2020 •
edited
Loading

@DamirPorobic If I understand this properly, instead of the 'Show Editor' action, the action performed when left-clicking would be configurable to 'Show Editor', 'Rectangular Area', 'Last Rectangular Area', etc.
Is this correct ?

Yes.

@DamirPorobic
Copy link
Member

Yes, exactly. I had a drop down menu in mind where you can select what's going to be opened. The tricky part is resolving this in code. Usually you would have an enum for the selection but here the capture options are dynamic, depending on OS and DE.

@fnkabit
Copy link
Contributor

fnkabit commented Dec 17, 2020

Understood. I would like to start working on this one.

@DamirPorobic DamirPorobic changed the title Feature request: Add option to select the default action for tray icon left click Add option to select the default action for tray icon left click Dec 17, 2020
@DamirPorobic
Copy link
Member

@fnkabit I think I would go for the enum, like DefaultTryIconActions consting of the ShowEditor and all existing CaptureOptions. Then, in the settings, I would filter out all not supported CaptureOptions from this new enum and allow the user only to select those that are supported.

@fnkabit fnkabit mentioned this issue Dec 17, 2020
Merged
DamirPorobic added a commit that referenced this issue Dec 19, 2020
@DamirPorobic
Split tray icon setting in own section #502
0ca0e06
DamirPorobic added a commit that referenced this issue Dec 19, 2020
@DamirPorobic
Refactor default tray icon action to use seperate enum #502
d08dd6c
@DamirPorobic
Copy link
Member

PR merged, thanks @fnkabit for implementing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fnkabit fnkabit

Labels
feature_request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DamirPorobic @erenseymen @fnkabit