Thanks to visit codestin.com
Credit goes to github.com

Skip to content

If file selection is cancelled during ksnip's file open dialog via tray icon, ksnip closes. #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erenseymen opened this issue Dec 13, 2020 · 6 comments · Fixed by #505
Closed

If file selection is cancelled during ksnip's file open dialog via tray icon, ksnip closes. #503

erenseymen opened this issue Dec 13, 2020 · 6 comments · Fixed by #505
Assignees
@fnkabit
Labels
bug

Comments

@erenseymen
Copy link

Steps:

  1. Right click on tray icon
  2. Select "Open"
    -- File selection window appears.
  3. Click on "Cancel" button in file selection window or close the file selection window
    -- ksnip crashes. FAIL

Note: I ran ksnip from terminal and there were no logs about the issue.
Note: If I use File>Open menu in the main window, there is no issue.

ksnip Version: 1.8.0 (Build: 1578-d84ec1a)
OS: Xubuntu 20.10
DE: Xfce 4.14
ksnip config file: ksnip.zip
@fnkabit
Copy link
Contributor

fnkabit commented Dec 14, 2020 •
edited
Loading

Issue only happens when the main window is hidden.
QFileDialog::getOpenFileNames terminates the application. Happens because the last window is closed.
Working on a fix.

This was referenced Dec 14, 2020
Closed
Merged
@DamirPorobic
Copy link
Member

I can't reproduce this issue on my side, running OpenSUSE with KDE Plasma. Might be effecting only specific Distros.

@DamirPorobic DamirPorobic changed the title Bug report: If file selection is cancelled during ksnip's file open dialog via tray icon, ksnip crashes. If file selection is cancelled during ksnip's file open dialog via tray icon, ksnip closes. Dec 14, 2020
@DamirPorobic
Copy link
Member

PR merged, should be fixed now in continuous build.

@fnkabit
Copy link
Contributor

fnkabit commented Dec 15, 2020

I can't reproduce this issue on my side, running OpenSUSE with KDE Plasma. Might be effecting only specific Distros.

I'm also running OpenSuse 15.2 KDE. For me, the issue occurs when the MainWindow is closed to system tray and you trigger the open action from system tray.

@DamirPorobic
Copy link
Member

Strange, tried exactly that and it stayed open. I'm using the exact same OS version like you.

Now you don't get the issue anymore with master?

@fnkabit
Copy link
Contributor

fnkabit commented Dec 15, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fnkabit fnkabit

Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@DamirPorobic @erenseymen @fnkabit