Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Main window still show after screenshot when corresponding option disabled #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DamirPorobic opened this issue Feb 26, 2021 · 21 comments
Closed
Assignees
Labels

Comments

@DamirPorobic
Copy link
Member

When uncheck Image Grabber - Show Main Window after capturing screenshot, after capturing by shortcut main window still shows.

Originally posted by @zyf0330 in #409 (comment)

@DamirPorobic
Copy link
Member Author

@zyf0330 With what ksnip version have you tested this? What OS/Distro?

Can you test this with 1.8.0 and the 1.9.0 continuous build?

@zyf0330
Copy link

zyf0330 commented Feb 26, 2021

@DamirPorobic Oh sorry, I tested with v1.8.1. And for 1.9.0, I don't find deb image.

@DamirPorobic
Copy link
Member Author

1.8.1 is fine, I just wanted to check if it was a change in 1.8.2 that I made it the other day.

What distro?

@zyf0330
Copy link

zyf0330 commented Feb 26, 2021

Ubuntu with kde
Linux hostname 5.4.0-66-generic #74-Ubuntu SMP Wed Jan 27 22:54:38 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Distributor ID: Ubuntu
Description:    Ubuntu 20.04.2 LTS
Release:        20.04
Codename:       focal

@DamirPorobic
Copy link
Member Author

Ok, I'll try to reproduce. One more thing, can you just for testing purpose try out the AppImage?

@zyf0330
Copy link

zyf0330 commented Feb 26, 2021

AppImage behaviors the same.

@DamirPorobic
Copy link
Member Author

Thanks

@fabianski7
Copy link
Contributor

with ksnip built from the master: if the window is minimized after taking a screenshot, it is not displayed. However if it is in the systray, the bug happens

@DamirPorobic
Copy link
Member Author

@fabianski7 sounds like a different issue. Can you please open a bug with descriptions what happens?

@fabianski7
Copy link
Contributor

I think it can be the same thing. I don't know if I described it well.
I will follow this and if the behavior continues even after it is fixed, I will report in a different one

@pkoerner81929
Copy link

Same here (Fedora, Gnome, X11, multiple screens, nvidia driver):

  • Unchecked: Show main window after capturing screenshot
  • Checked: Hide Main Window during screenshot
  • ksnip in systray. Using Alt-Shift-L to repeat screenshot of previous area.
  • ksnip window appears after screenshot (unwanted behaviour..)

@DamirPorobic
Copy link
Member Author

I'll have a look into it. It looks to me as a change in the Qt code that handles the minimizing because you see it with newer version and I with my 5.12 don't.

@DamirPorobic DamirPorobic changed the title When uncheck "Show Main Window after capturing screenshot" after capturing by shortcut main window still shows. Main window still show after screenshot when corresponding option disabled Mar 18, 2021
@DamirPorobic
Copy link
Member Author

I have pushed a fix for this issue, can you please test?

@pkoerner81929
Copy link

Main window still always appears after taking screenshot with e.g. Alt-Shift-L. No matter if it has been closed/minimized.

Version: 1.9.0-continuous
Build: 1922-cf37c30

@DamirPorobic
Copy link
Member Author

Peter, you are too fast for the CI xD
image

@pkoerner81929
Copy link

:-)

@pkoerner81929
Copy link

Version: 1.9.0-continuous
Build: 1925-dd6dc12

Behaviour changed:

  • If minimized (using "-" icon on window), capture window stays in windowlist one time. At second try it re-appears. If hidden again, it stays hidden in windowlist for the next multiple screenshots.
  • If closed (using "x" icon on window), ksnip goes to tray in background and does always re-appear after e.g. Alt-Shift-L

@DamirPorobic
Copy link
Member Author

Ok, that with clicking close was kind of obvious, that didn't work for me too on my Plasma. The behavior with once coming up and then being hidden with the minimize button I couldn't reproduce on my Plasma or Gnome on Ubuntu 20.10.
I have pushed now a change that should fix the close issue but might also have an effect on the minimize issue, can you please try again and report back how it behaves for you now, the commit hash should be 1d60431.

If the issue persists I'll try next reproducing it on Fedora Gnome.

@DamirPorobic
Copy link
Member Author

@pkoerner81929 can you have a look at the fix, is it working now? I'm planning on releasing 1.8.2 soon and would like this fix to be in there.

@pkoerner81929
Copy link

Yes, works as expected. Great job!

@DamirPorobic
Copy link
Member Author

Nice, thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants