Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cancel screenshot shows main window when window was hidden #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ljubadr opened this issue Mar 11, 2021 · 12 comments
Closed

Cancel screenshot shows main window when window was hidden #607

ljubadr opened this issue Mar 11, 2021 · 12 comments
Assignees
@DamirPorobic
Labels
bug

Comments

@ljubadr
Copy link

ljubadr commented Mar 11, 2021

Is your feature request related to a problem? Please describe.
Currently when I start taking screenshot I and I press Esc key main ksnip window comes into focus even though no screenshot was taken

Describe the solution you'd like
I would like to be able to cancel the screenshot with Esc without ksnip window taking focus
@DamirPorobic
Copy link
Member

I think we have fixed that in 1.8.1, this was the issue #521

With the latest version I cannot reproduce that issue.

What OS/Distro are you using?

@fabianski7
Copy link
Contributor

I confirm this bug
I'm at the master, archlinux.

perhaps related to #596?

@DamirPorobic
Copy link
Member

@fabianski7 for you too when you hit cancel and the window was hidden before the screenshot, afterwards the window is show?

@fabianski7
Copy link
Contributor

fabianski7 commented Mar 12, 2021 •
edited
Loading

@fabianski7 for you too when you hit cancel and the window was hidden before the screenshot, afterwards the window is show?

yes

@DamirPorobic
Copy link
Member

Is this with Gnome or Plasma? X11 or Wayland?

@fabianski7
Copy link
Contributor

Operating System: Arch Linux
KDE Plasma Version: 5.21.2
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Kernel Version: 5.11.4-arch1-1
Graphics Platform: X11

@ljubadr
Copy link
Author

ljubadr commented Mar 13, 2021

I'm using Ubuntu 20.04

Linux hostname 5.4.0-59-generic #65-Ubuntu SMP Thu Dec 10 12:01:51 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Currently I'm using the ksnip version 1.8.1, but I've also tested this on 1.9.0-continuous and it happens there as well...

@DamirPorobic DamirPorobic changed the title Cancel the screenshot without opening the main ksnip window Cancel screenshot shows main window when window was hidden Mar 18, 2021
DamirPorobic added a commit that referenced this issue Mar 18, 2021
@DamirPorobic
Fix main window shown after canceling or taking screenshot #596 #607
4aee67e
@DamirPorobic
Copy link
Member

I have pushed a fix for this issue, can you please test?

@fabianski7
Copy link
Contributor 

KDE Plasma Version: 5.21.3
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2
Kernel Version: 5.11.6-arch1-1
Graphics Platform: X11

still the same

@DamirPorobic DamirPorobic self-assigned this Mar 18, 2021
DamirPorobic added a commit that referenced this issue Mar 18, 2021
@DamirPorobic
Handle hidden window state in visibility handler #596 #607
c9f125a
@DamirPorobic
Copy link
Member

@fabianski7 can you see what the last commit hash is? And maybe give it another try, I have pushed a change to the code for the other issue, maybe it has some effect on this one.

@fabianski7
Copy link
Contributor

I just built it with the last commit (1d60431) and it's fixed. thanks!

@DamirPorobic
Copy link
Member

Awesome, thanks for confirming.

@fabianski7 fabianski7 mentioned this issue Mar 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DamirPorobic DamirPorobic

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DamirPorobic @ljubadr @fabianski7