Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow setting Imgur upload title/description #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LastTalon opened this issue Jun 30, 2021 · 4 comments
Closed

Allow setting Imgur upload title/description #679

LastTalon opened this issue Jun 30, 2021 · 4 comments
Assignees
@DamirPorobic
Labels
feature_request

Comments

@LastTalon
Copy link

It would be really useful for my workflow if the Imgur uploader configuration had fields for the default title and description to use for uploads and/or the option to leave them without a title or description.
@DamirPorobic
Copy link
Member

Sounds like a useful feature. PRs are welcome :)

@LastTalon
Copy link
Author

I'll see if I can have a look at the code later since it does sound like good first issue. I'm not great with C++ though, so I would appreciate any tips or pointers once the PR is up.

@DamirPorobic
Copy link
Member

Sure, not a problem. Have a look and let me know if you have any questions.
Your starting point should be /src/backend/uploader/imgur/ImgurWrapper.cpp:52 there the title and description are set. Currently the values are hardcoded, maybe passing some kind of details dto object to that method with title and description that are loaded from config will do the trick.

@fnkhz fnkhz mentioned this issue Jan 12, 2022
Merged
@DamirPorobic DamirPorobic self-assigned this Jan 12, 2022
@DamirPorobic
Copy link
Member

This has been implemented by @fnkhz, kudos to him!

@DamirPorobic DamirPorobic changed the title Default Imgur upload title/description configuration Allow setting Imgur upload title/description Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DamirPorobic DamirPorobic

Labels
feature_request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LastTalon @DamirPorobic