Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Windows packages increased in size #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smaragdus opened this issue Sep 16, 2021 · 5 comments
Closed

Windows packages increased in size #713

smaragdus opened this issue Sep 16, 2021 · 5 comments
Assignees
@DamirPorobic
Labels
bug

Comments

@smaragdus
Copy link

@DamirPorobic

I was surprised to see that within a single minor release (from version 1.9.0 to version 1.9.1) the Windows version of ksnip had become 3 to 4 times bigger in size:

  • ksnip version 1.9.0, archive (ksnip-1.9.0-windows.zip) - 11.6 MB compressed, 29.5 MB uncompressed
  • ksnip version 1.9.1, archive (ksnip-1.9.1-windows.zip) - 45.5 MB compressed, 81.3 MB uncompressed

I saw that the main culprits for this tremendous increase in size are these:

  • vc_redist.x64.exe
  • opengl32sw.dll

I think that Microsoft Visual C++ 2015-2019 Redistributable should not be included in the in the program, while ksnip seems to be working fine without OpenGL library, What do you think?

I am not nagging, I am sure that you are doing your best to improve the program and I know that efficiency with cross-platform software is unattainable yet I think that 81.3 MB (uncompressed) for a screen capture program is too much, it looks unsavoury and even scary as it begins to resemble Electron monstrosities in size.

Regards
@DamirPorobic
Copy link
Member

Agree on that one, I have noticed it too. The issue comes from the migration of the CI, we are building now on Github Actions and here the Qt version is higher and so is the windeployqt, which selected the dependencies for our build. Simply deleting worked for the exe but msi is more problematic because it's packaged in one operation. I'll see what I can do here, eventually going with an older Qt version.

@DamirPorobic DamirPorobic self-assigned this Sep 18, 2021
@DamirPorobic DamirPorobic changed the title Size [Question] Windows packages increased in size Sep 18, 2021
DamirPorobic added a commit that referenced this issue Sep 18, 2021
@DamirPorobic
Dont package unused dependencies for windows #713
cb78327
DamirPorobic added a commit that referenced this issue Sep 18, 2021
@DamirPorobic
Set winddeployqt flags #713
dcabc5d
@DamirPorobic
Copy link
Member

Pushed a fix for the exe package, let's see if it works.

@DamirPorobic
Copy link
Member

Looks indeed smaller, can you check out if the exe is starting?

@smaragdus
Copy link
Author

@DamirPorobic

Looks indeed smaller, can you check out if the exe is starting?

Yes it does start and does work normally,

screen:

ksnip 1 10 0-1-370f975 - 2021-09-19 - 001

I tested in on Windows 8 (x64) and I did not encounter any problems.

Regards

DamirPorobic added a commit that referenced this issue Sep 19, 2021
@DamirPorobic
Set windeployqt flags for msi build #713
b8b40bd
@DamirPorobic
Copy link
Member

Reduced msi package too.

@DamirPorobic DamirPorobic mentioned this issue Oct 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DamirPorobic DamirPorobic

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smaragdus @DamirPorobic