-
-
Notifications
You must be signed in to change notification settings - Fork 198
Screenshot area issues when monitor count changes on windows #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, valid issue. Problem is that that we only on startup detect what the scaling and screen size is. We need some mechanic to detect a change there, I think it is supported by Qt. |
Yeah, makes sense that it isn't too easy to detect when the screen changes -- is the current solution to just quit and restart each time? |
Yeah, I don't think that there is an alternative in the moment. |
We should be able to handle that automatically, Qt can inform us about changed screen counts https://doc.qt.io/qt-5/qguiapplication.html#screenRemoved, we just need to listen to the signal and recalculate the display. |
I'll see if I can provide a fix tomorrow. |
@200210qb I've pushed a quick fix, if you want to test latest build and see if the behavior has improved. |
Hey! Thanks a ton for the fix -- however, when I plug in a second monitor to my laptop on ksnip continuous 1.10, screenshotting still shows both monitors squished onto my main monitor |
Is it the same as before or a different behavior? |
I believe it's the same behavior |
Well, that happens when you write code without testing. Anyways, I believe I have fixed that now, I was able to reproduce and fix it locally, can you please test it one more time. The CI needs ~20min from now to build the package. |
Assuming this one is fixed now, closing the issue, please reopen if the issue persists. |
Sorry -- just had a chance to test. I think it's fixed when going from extended monitors to just one monitor, but when I go from my laptop screen to extended, I still see both monitors squished onto my laptop monitor. |
I'm not sure that I get what this means? You have an extended monitors and laptop and then turn of the laptop monitor? |
If I open ksnip with just my laptop, then plug in an external monitor that extends the laptop above, ksnip's screenshot area will squish both screens onto just the laptop screen |
So it works when you remove one monitor after ksnip was started but not when you add one monitor? |
Yes -- before, changing from extended mode to single laptop would do a weird offset when I screenshotted, but that seems to be fixed. EDIT: I just tested again (I think the first time I did something different), but actually it doesn't seem this is fixed. When I move from extended to laptop, I get a very zoomed in and distorted screenshot area. |
I cannot reproduce that. What I'm doing is start ksnip, the power off one monitor, take screenshot, looks ok, then close ksnip. Next I tried starting ksnip with one monitor still turned of, then power on the one monitor that I have power off eralier, take screenshot, looks ok. Can you check if we are using the same version? |
I'm on Version: 1.10.0-continuous, Build: 1-302efd3 |
You just start ksnip and don't take any screenshots before plugging in the second monitor? Oh and you have installed it via MSI? Can you test with the zip package? Really strange, for me seems to be working, don't know what the difference is that might be causing it. |
I'll test the zip right now |
Yes -- I get the same bug with the zip Version: 1.10.0-continuous Build: 1-ba9af9f |
Pushed a version now that should log to a file in your documents directory every time a screen change occurs. The CI need a couple of minutes to build it. Can you please test and share the log content here? |
@dchen327 can you check again and share the mentioned log? |
As I haven't got any feedback from you I'll be removing the logger and this issue from the 1.9.2 patch. |
I also have this bug. Maybe the issue is not monitor count, but monitor layout. Here is a screen recording of me reproducing the bug: I'm running: |
Describe the bug
If ksnip is launched on just a laptop screen, when a second monitor is plugged in and extends the first, taking a screenshot puts the two screens squished onto the main laptop, and the screenshot area is broken. A relaunch of ksnip fixes this issue; however, after switching from extended back to single laptop display, ksnip opened in extended mode will stretch the screenshot area a bit on the main laptop.
To Reproduce
Expected behavior
I'd expect the screenshot cursor to show up on both monitors, but instead both screens get squished onto the laptop, and the cursor can't be moved to the top monitor (the cross goes blank).
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: