Fix: With TolerateUnready set, endpoints are still listed for a Pod in state terminating

simonswine · simonswine · commit d282f47496c8 · 2016-11-18T16:02:42.000Z
* Otherwise it prevents long running task in a preStop hook to succeed,
that require DNS resolution

should lis available even when Pods are in termi
diff --git a/pkg/controller/endpoint/endpoints_controller.go b/pkg/controller/endpoint/endpoints_controller.go
@@ -402,7 +402,7 @@ func (e *EndpointController) syncService(key string) error {
 				glog.V(5).Infof("Failed to find an IP for pod %s/%s", pod.Namespace, pod.Name)
 				continue
 			}
-			if pod.DeletionTimestamp != nil {
+			if !tolerateUnreadyEndpoints && pod.DeletionTimestamp != nil {
 				glog.V(5).Infof("Pod is being deleted %s/%s", pod.Namespace, pod.Name)
 				continue
 			}

Original file line number	Diff line number	Diff line change
`@@ -402,7 +402,7 @@ func (e *EndpointController) syncService(key string) error {`
`402`	`402`	`glog.V(5).Infof("Failed to find an IP for pod %s/%s", pod.Namespace, pod.Name)`
`403`	`403`	`continue`
`404`	`404`	`}`
`405`		`- if pod.DeletionTimestamp != nil {`
	`405`	`+ if !tolerateUnreadyEndpoints && pod.DeletionTimestamp != nil {`
`406`	`406`	`glog.V(5).Infof("Pod is being deleted %s/%s", pod.Namespace, pod.Name)`
`407`	`407`	`continue`
`408`	`408`	`}`