Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug in ThirdPartyResourcesApi (hardcoded resource path) #256

Closed
@ebbeelsborg

Description

@ebbeelsborg

This project is awesome and I was delighted to see #216 get merged.

There is a bug when constructing the resource paths, however: For instance, in the class ThirdPartyResourcesApi, on line 126 (+/-):

resource_path = '/apis/{fqdn}/v1/namespaces/{namespace}/{resource}'.replace('{format}', 'json')

This does not work for third-party resources which are not of version 'v1' exactly. So, for example, the apiVersion "monitoring.coreos.com/v1alpha1" fails with a 404.

I suggest taking in the version as a formal parameter in the relevant methods and injecting it in the resource path.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions