Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Wrong Github link in auto-generated README  #952

Closed
@roycaihw

Description

@roycaihw

What happened (please include outputs or screenshots):
ref #931 (comment)

What you expected to happen:
the generated address should be git+https://github.com/kubernetes-client/python.git

How to reproduce it (as minimally and precisely as possible):
run scripts/update-client.sh, and see the link in kubernetes/README.md

Anything else we need to know?:
This has been happening since we graduated this repo from kubernetes-incubator/client-python to kubernetes-client/python

The link seems to be composed as

git+https://github.com/GIT_USER_ID/GIT_REPO_ID.git

according to https://github.com/swagger-api/swagger-codegen/blob/master/samples/client/petstore/python/README.md#pip-install

however, the IDs that we use in gen repo look reasonable: https://github.com/kubernetes-client/gen/blob/795993978f8563a9c09089993be4d2b97d492eec/openapi/python.xml#L22-L23

Environment:

  • OS (e.g., MacOS 10.13.6): MacOS 10.14.6
  • Python version (python --version): 2.7.12
  • Python client version (pip list | grep kubernetes): master branch HEAD

Metadata

Metadata

Assignees

Labels

help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions