Amendment to PR 270 (issue #262) #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4 which has again become broken
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
mbohlool
reviewed
Jul 20, 2017
requirements.txt
Outdated
| @@ -6,4 +6,4 @@ urllib3>=1.19.1,!=1.21 # MIT | |||
| pyyaml>=3.12 # MIT | |||
| google-auth>=1.0.1 # Apache-2.0 | |||
| ipaddress>=1.0.17 # PSF | |||
| websocket-client>=0.32.0 # LGPLv2+ | |||
| websocket-client<=0.40.0 # LGPLv2+ | |||
There was a problem hiding this comment.
Sure, yes, that makes sense....
…han or equal to 0.32.0 is used
|
LGTM. @jonastl does this look good? |
jonastl
approved these changes
Jul 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue surround #262 which was fixed in version 0.43 of websocket-client, has been reintroduced in version 0.44.0
This PR updates the requirements so websocket-client will go no further than 0.40.0