From 2d1d8e6d9dbb186c088da56482825393a70f713e Mon Sep 17 00:00:00 2001 From: Yacov Malen <49476663+ymalen@users.noreply.github.com> Date: Thu, 4 Jul 2019 11:12:54 +0300 Subject: [PATCH 1/2] Update README.md Update the documentation to note an issue with using stream and the api client. --- README.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/README.md b/README.md index cb54c39abc..5afa9d35e6 100644 --- a/README.md +++ b/README.md @@ -185,3 +185,8 @@ Specifically check `ipaddress` and `urllib3` package versions to make sure they Starting from 4.0 release, we do not support directly calling exec or attach calls. you should use stream module to call them. so instead of `resp = api.connect_get_namespaced_pod_exec(name, ...` you should call `resp = stream(api.connect_get_namespaced_pod_exec, name, ...`. See more at [exec example](examples/exec.py). + + Using Stream will overwrite the requests protocol in _core_v1_api.CoreV1Api()_ + This will cause a failure in non-exec/attach calls. If you reuse your api client object, you will need to + recreate it between api calls that use _stream_ and other api calls. + From d89c7f6a5fdf7ba24571a0fc15ff7b5a93dd631d Mon Sep 17 00:00:00 2001 From: Yacov Malen <49476663+ymalen@users.noreply.github.com> Date: Wed, 23 Oct 2019 11:06:53 +0300 Subject: [PATCH 2/2] Update README.md --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 5afa9d35e6..8af2972797 100644 --- a/README.md +++ b/README.md @@ -186,7 +186,7 @@ Starting from 4.0 release, we do not support directly calling exec or attach cal of `resp = api.connect_get_namespaced_pod_exec(name, ...` you should call `resp = stream(api.connect_get_namespaced_pod_exec, name, ...`. See more at [exec example](examples/exec.py). - Using Stream will overwrite the requests protocol in _core_v1_api.CoreV1Api()_ - This will cause a failure in non-exec/attach calls. If you reuse your api client object, you will need to - recreate it between api calls that use _stream_ and other api calls. +Using Stream will overwrite the requests protocol in _core_v1_api.CoreV1Api()_ +This will cause a failure in non-exec/attach calls. If you reuse your api client object, you will need to +recreate it between api calls that use _stream_ and other api calls.