Fix: make ENVTEST_K8S_VERSION respect go.mod replace directives

Shubhamag12 · Shubhamag12 · commit 2cacaf40e918 · 2025-09-17T15:18:07.000+05:30
diff --git a/pkg/plugins/golang/v4/scaffolds/internal/templates/makefile.go b/pkg/plugins/golang/v4/scaffolds/internal/templates/makefile.go
@@ -269,7 +269,8 @@ CONTROLLER_TOOLS_VERSION ?= {{ .ControllerToolsVersion }}
 #ENVTEST_VERSION is the version of controller-runtime release branch to fetch the envtest setup script (i.e. release-0.20)
 ENVTEST_VERSION ?= $(shell go list -m -f "{{ "{{ .Version }}" }}" sigs.k8s.io/controller-runtime | awk -F'[v.]' '{printf "release-%d.%d", $$2, $$3}')
 #ENVTEST_K8S_VERSION is the version of Kubernetes to use for setting up ENVTEST binaries (i.e. 1.31)
-ENVTEST_K8S_VERSION ?= $(shell go list -m -f "{{ "{{ .Version }}" }}" k8s.io/api | awk -F'[v.]' '{printf "1.%d", $$3}')
+ENVTEST_K8S_VERSION ?= $(shell go list -m k8s.io/api | \
+  awk '{if ($$NF ~ /^v[0-9]/) {gsub(/^v/,"",$$NF); split($$NF,v,"."); major=v[1]; minor=v[2]; if (major==0) major=1; printf "%d.%d", major, minor} else {print "Error: Cannot detect version. Set ENVTEST_K8S_VERSION manually." > "/dev/stderr"; exit 1}}')
 GOLANGCI_LINT_VERSION ?= {{ .GolangciLintVersion }}
 
 .PHONY: kustomize
diff --git a/testdata/project-v4-multigroup/Makefile b/testdata/project-v4-multigroup/Makefile
@@ -190,7 +190,8 @@ CONTROLLER_TOOLS_VERSION ?= v0.19.0
 #ENVTEST_VERSION is the version of controller-runtime release branch to fetch the envtest setup script (i.e. release-0.20)
 ENVTEST_VERSION ?= $(shell go list -m -f "{{ .Version }}" sigs.k8s.io/controller-runtime | awk -F'[v.]' '{printf "release-%d.%d", $$2, $$3}')
 #ENVTEST_K8S_VERSION is the version of Kubernetes to use for setting up ENVTEST binaries (i.e. 1.31)
-ENVTEST_K8S_VERSION ?= $(shell go list -m -f "{{ .Version }}" k8s.io/api | awk -F'[v.]' '{printf "1.%d", $$3}')
+ENVTEST_K8S_VERSION ?= $(shell go list -m k8s.io/api | \
+  awk '{if ($$NF ~ /^v[0-9]/) {gsub(/^v/,"",$$NF); split($$NF,v,"."); major=v[1]; minor=v[2]; if (major==0) major=1; printf "%d.%d", major, minor} else {print "Error: Cannot detect version. Set ENVTEST_K8S_VERSION manually." > "/dev/stderr"; exit 1}}')
 GOLANGCI_LINT_VERSION ?= v2.4.0
 
 .PHONY: kustomize
diff --git a/testdata/project-v4-with-plugins/Makefile b/testdata/project-v4-with-plugins/Makefile
@@ -190,7 +190,8 @@ CONTROLLER_TOOLS_VERSION ?= v0.19.0
 #ENVTEST_VERSION is the version of controller-runtime release branch to fetch the envtest setup script (i.e. release-0.20)
 ENVTEST_VERSION ?= $(shell go list -m -f "{{ .Version }}" sigs.k8s.io/controller-runtime | awk -F'[v.]' '{printf "release-%d.%d", $$2, $$3}')
 #ENVTEST_K8S_VERSION is the version of Kubernetes to use for setting up ENVTEST binaries (i.e. 1.31)
-ENVTEST_K8S_VERSION ?= $(shell go list -m -f "{{ .Version }}" k8s.io/api | awk -F'[v.]' '{printf "1.%d", $$3}')
+ENVTEST_K8S_VERSION ?= $(shell go list -m k8s.io/api | \
+  awk '{if ($$NF ~ /^v[0-9]/) {gsub(/^v/,"",$$NF); split($$NF,v,"."); major=v[1]; minor=v[2]; if (major==0) major=1; printf "%d.%d", major, minor} else {print "Error: Cannot detect version. Set ENVTEST_K8S_VERSION manually." > "/dev/stderr"; exit 1}}')
 GOLANGCI_LINT_VERSION ?= v2.4.0
 
 .PHONY: kustomize
diff --git a/testdata/project-v4/Makefile b/testdata/project-v4/Makefile
@@ -190,7 +190,8 @@ CONTROLLER_TOOLS_VERSION ?= v0.19.0
 #ENVTEST_VERSION is the version of controller-runtime release branch to fetch the envtest setup script (i.e. release-0.20)
 ENVTEST_VERSION ?= $(shell go list -m -f "{{ .Version }}" sigs.k8s.io/controller-runtime | awk -F'[v.]' '{printf "release-%d.%d", $$2, $$3}')
 #ENVTEST_K8S_VERSION is the version of Kubernetes to use for setting up ENVTEST binaries (i.e. 1.31)
-ENVTEST_K8S_VERSION ?= $(shell go list -m -f "{{ .Version }}" k8s.io/api | awk -F'[v.]' '{printf "1.%d", $$3}')
+ENVTEST_K8S_VERSION ?= $(shell go list -m k8s.io/api | \
+  awk '{if ($$NF ~ /^v[0-9]/) {gsub(/^v/,"",$$NF); split($$NF,v,"."); major=v[1]; minor=v[2]; if (major==0) major=1; printf "%d.%d", major, minor} else {print "Error: Cannot detect version. Set ENVTEST_K8S_VERSION manually." > "/dev/stderr"; exit 1}}')
 GOLANGCI_LINT_VERSION ?= v2.4.0
 
 .PHONY: kustomize
