Thanks to visit codestin.com
Credit goes to github.com

Skip to content

itictactoe No winner if win at the last turn #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ceilinglight opened this issue May 5, 2021 · 1 comment
Closed

itictactoe No winner if win at the last turn #16

ceilinglight opened this issue May 5, 2021 · 1 comment

Comments

@ceilinglight
Copy link

ceilinglight commented May 5, 2021 •
edited
Loading

Hi,

In chapter 22 Tic-Tac-Toe redux: An interactive version with type hints, the solution doesn't declare a winner if they win at the last turn. Here's the output from tiny_python_projects/22_itictactoe/solution1.py

-------------
| X | O | O |
-------------
| X | O | X |
-------------
| 7 | X | O |
-------------
Player X, what is your move? [q to quit]: 7
All right, we'll call it a draw.

The program should check for a draw after displaying a new board and finding a winner.
@kyclark
Copy link
Owner

kyclark commented Dec 8, 2021

You're right! I should do all the checks before getting the next move.

@kyclark kyclark closed this as completed Dec 8, 2021
kyclark added a commit that referenced this issue Dec 8, 2021
@kyclark
fix for #16
0e73a0d
mjam0 added a commit to mjam0/tiny_python_projects that referenced this issue Sep 21, 2023
@mjam0
fix for kyclark#16
4cfebb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyclark @ceilinglight