This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Refactor contextual shared objects to be statically typed in nested aiohttp apps #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #400 +/- ##
==========================================
+ Coverage 46.09% 46.57% +0.48%
==========================================
Files 49 51 +2
Lines 7684 8283 +599
==========================================
+ Hits 3542 3858 +316
- Misses 4142 4425 +283
Continue to review full report at Codecov.
|
* Fix several regressions due to missing updates for AgentRegistry API changes, such as session restarts. * The installed/installed_agents fields for the list of image metadata is now only supported in GraphQL queries, not the manager CLI commands (`mgr etcd inspect-image`, `mgr etcd list-images`).
* setup: Add yapf configuration based on the "facebook" style
which is mostly consistent with my coding style.
- e.g., it keeps lines split for items/arguments if the ending item
has the trailing comma.
…der}
* Also fix up some minor bits in models.{agent,gql} and gateway.admin
* fix reference to root context field in gateway.manager
achimnol
added a commit
to lablup/backend.ai-common
that referenced
this pull request
Mar 15, 2021
* Let's favor "| None" instead of "Optional" for better readability
- This will be officially introduced in Python 3.10 but currently
we can use it for annotations with future import.
achimnol
added a commit
that referenced
this pull request
Mar 18, 2021
…iohttp apps (#400) This PR makes all contextual objects to be statically typed and explicitly defined as attributes of common context objects in the following context: 1. aiohttp.web.Application context, both "root" and "private" ones for nested API handler app structure - The root context replaces prior "public shared interface" 2. GraphQueryContext for all GraphQL resolver and mutation methods 3. CLIContext for all manager CLI functions I also added yapf configuration for easier reformatting of long method/function argument lists by enforcing line-breaks per argument when there is a trailing comma in the list. Other changes: * Increase the default batch size for the GraphQL dataloader to reduce database overheads * Fix several regressions due to missing updates for AgentRegistry API changes, such as session restarts. * The installed/installed_agents fields for the list of image metadata is now only supported in GraphQL queries, not the manager CLI commands (`mgr etcd inspect-image`, `mgr etcd list-images`). Backported-From: main Backported-To: 20.09
achimnol
added a commit
to lablup/backend.ai-common
that referenced
this pull request
Mar 18, 2021
achimnol
added a commit
to lablup/backend.ai-common
that referenced
this pull request
Mar 18, 2021
Backported-From: main Backported-To: 20.09
achimnol
added a commit
that referenced
this pull request
Mar 19, 2021
achimnol
added a commit
that referenced
this pull request
Mar 19, 2021
achimnol
added a commit
that referenced
this pull request
Mar 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal ticket: OP#1164