This repository was archived by the owner on Aug 2, 2023. It is now read-only.
fix: do not register sub containers to existing sessions if main container is TERMINATED #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainer is TERMINATED
Codecov Report
@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 46.09% 46.07% -0.02%
==========================================
Files 49 49
Lines 7684 7687 +3
==========================================
Hits 3542 3542
- Misses 4142 4145 +3
Continue to review full report at Codecov.
|
achimnol
pushed a commit
that referenced
this pull request
Mar 8, 2021
…ainer is TERMINATED (#403) Backported-From: main Backported-To: 20.09
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, sub containers are still RUNNING even though main container is TERMINATED, which we can call broken session. In this case, the scheduler for the scaling group which contains the broken session is unable to schedule PENDING sessions at all. To circumvent this edge case, we exclude broken sessions, that do not have main container, from fetching existing session list.