Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 2, 2023. It is now read-only.

fix: idle_timeout was not working due to last_access save error #404

Merged
merged 2 commits into from
Mar 18, 2021
Merged

fix: idle_timeout was not working due to last_access save error #404

merged 2 commits into from
Mar 18, 2021

Conversation

@adrysn
Copy link
Member

@adrysn adrysn commented Mar 15, 2021 •
edited
Loading

expire parameter in aioredis's set method explicitly requires int type and float is not allowed.

@adrysn adrysn self-assigned this Mar 15, 2021
@adrysn adrysn added this to the 20.09 milestone Mar 15, 2021
@adrysn adrysn requested a review from achimnol March 15, 2021 00:47
@adrysn adrysn added the bug label Mar 15, 2021
@codecov
Copy link

codecov bot commented Mar 15, 2021 •
edited
Loading

Codecov Report

Merging #404 (f663036) into main (41b5c38) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #404   +/-   ##
=======================================
  Coverage   46.07%   46.07%           
=======================================
  Files          49       49           
  Lines        7687     7687           
=======================================
  Hits         3542     3542           
  Misses       4145     4145
Impacted Files Coverage Δ
src/ai/backend/gateway/config.py 44.78% <ø> (ø)
src/ai/backend/manager/idle.py 41.81% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41b5c38...f663036. Read the comment docs.

@achimnol achimnol merged commit e4b2597 into main Mar 18, 2021
@achimnol achimnol deleted the fix/idle-timeout-not-working-due-to-last_access-set-error branch March 18, 2021 09:32
achimnol pushed a commit that referenced this pull request Mar 18, 2021
@adrysn @achimnol
fix: idle_timeout was not working due to last_access save error (#404)
0ec3cb4 
Backported-From: main
Backported-To: 20.09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@achimnol achimnol Awaiting requested review from achimnol

Assignees

@adrysn adrysn

Labels

bug

Projects

None yet

Milestone

20.09

Development

Successfully merging this pull request may close these issues.

3 participants

@adrysn @achimnol