Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 2, 2023. It is now read-only.

fix: Add check for pgsql version to adjust connection args #407

Merged
merged 6 commits into from
Mar 25, 2021
Merged

fix: Add check for pgsql version to adjust connection args #407

merged 6 commits into from
Mar 25, 2021

Conversation

@achimnol
Copy link
Member

@achimnol achimnol commented Mar 24, 2021 •
edited
Loading

This is a follow-up to #406, to keep the manager compatible with PostgreSQL v10 or older, where the JIT option is not available.

@achimnol achimnol added this to the 20.09 milestone Mar 24, 2021
@achimnol achimnol added the bug label Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021 •
edited
Loading

Codecov Report

Merging #407 (ee65be2) into main (cd7479a) will decrease coverage by 0.03%.
The diff coverage is 47.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   48.66%   48.62%   -0.04%     
==========================================
  Files          52       52              
  Lines        8267     8279      +12     
==========================================
+ Hits         4023     4026       +3     
- Misses       4244     4253       +9
Impacted Files Coverage Δ
src/ai/backend/gateway/auth.py 51.41% <0.00%> (ø)
src/ai/backend/manager/models/vfolder.py 41.32% <ø> (ø)
src/ai/backend/gateway/server.py 59.00% <50.00%> (-1.06%) ⬇️
src/ai/backend/manager/models/base.py 54.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7479a...ee65be2. Read the comment docs.

@achimnol achimnol requested a review from adrysn March 24, 2021 15:19
adrysn
adrysn approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@adrysn adrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works in my test environment. I've committed some fixes and check if you are okay with them.

@achimnol
Copy link
Member Author

achimnol commented Mar 25, 2021

Thanks for extra fixes!

@achimnol achimnol merged commit 3378361 into main Mar 25, 2021
@achimnol achimnol deleted the fix/pgsql-version-check branch March 25, 2021 12:46
achimnol added a commit that referenced this pull request Mar 25, 2021
@achimnol @adrysn
fix: Add check for pgsql version to adjust connection args (#407)
60d13af 
* Follow-up fixes for #406
  - fix: sqlalchemy's Row Proxy's get() method seems to be deprecated
  - fix: typo in referencing unmanaged_path

Co-authored-by: Jonghyun Park <[email protected]>
Backported-From: main
Backported-To: 20.09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@adrysn adrysn adrysn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

20.09

Development

Successfully merging this pull request may close these issues.

3 participants

@achimnol @adrysn