[11.x] Test Improvements (#49271)

crynobone · web-flow · commit 6e302e8aadf1 · 2023-12-09T09:19:58.000-06:00
Signed-off-by: Mior Muhammad Zaki &lt;crynobone@gmail.com&gt;
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -68,7 +68,6 @@ jobs:
           timeout_minutes: 5
           max_attempts: 5
           command: composer require guzzlehttp/psr7:^2.4 --no-interaction --no-update
-        if: matrix.php >= 8.2
 
       - name: Install dependencies
         uses: nick-fields/retry@v2
@@ -131,7 +130,6 @@ jobs:
           timeout_minutes: 5
           max_attempts: 5
           command: composer require guzzlehttp/psr7:~2.4 --no-interaction --no-update
-        if: matrix.php >= 8.2
 
       - name: Install dependencies
         uses: nick-fields/retry@v2
diff --git a/tests/Integration/Http/ThrottleRequestsTest.php b/tests/Integration/Http/ThrottleRequestsTest.php
@@ -11,6 +11,7 @@
 use Illuminate\Support\Carbon;
 use Illuminate\Support\Facades\Route;
 use Orchestra\Testbench\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 use Throwable;
 
 class ThrottleRequestsTest extends TestCase
@@ -127,7 +128,7 @@ public static function perMinuteThrottlingDataSet()
         ];
     }
 
-    /** @dataProvider perMinuteThrottlingDataSet */
+    #[DataProvider('perMinuteThrottlingDataSet')]
     public function testItCanThrottlePerMinute(string $middleware)
     {
         $rateLimiter = Container::getInstance()->make(RateLimiter::class);

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@`
`11`	`11`	`use Illuminate\Support\Carbon;`
`12`	`12`	`use Illuminate\Support\Facades\Route;`
`13`	`13`	`use Orchestra\Testbench\TestCase;`
	`14`	`+use PHPUnit\Framework\Attributes\DataProvider;`
`14`	`15`	`use Throwable;`
`15`	`16`
`16`	`17`	`class ThrottleRequestsTest extends TestCase`
`@@ -127,7 +128,7 @@ public static function perMinuteThrottlingDataSet()`
`127`	`128`	`];`
`128`	`129`	`}`
`129`	`130`
`130`		`- /** @dataProvider perMinuteThrottlingDataSet */`
	`131`	`+ #[DataProvider('perMinuteThrottlingDataSet')]`
`131`	`132`	`public function testItCanThrottlePerMinute(string $middleware)`
`132`	`133`	`{`
`133`	`134`	`$rateLimiter = Container::getInstance()->make(RateLimiter::class);`