From d662538d33b9909ae9a352db5202fd8653a3bdc2 Mon Sep 17 00:00:00 2001 From: s4muel Date: Tue, 16 Nov 2021 08:44:20 +0100 Subject: [PATCH] fix(rollback) required_if and exclude_if validation i think you do not want to return early in these cases as @driesvints changed in this PR: https://github.com/laravel/framework/pull/37128 that PR broke using this validation for `null` values (e.g. checkboxes that are not checked) so you cannot use it like `exclude_if,otherfield,null` --- .../Validation/Concerns/ValidatesAttributes.php | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/Illuminate/Validation/Concerns/ValidatesAttributes.php b/src/Illuminate/Validation/Concerns/ValidatesAttributes.php index 9b3f3b3215b0..e427c5917c33 100644 --- a/src/Illuminate/Validation/Concerns/ValidatesAttributes.php +++ b/src/Illuminate/Validation/Concerns/ValidatesAttributes.php @@ -1509,10 +1509,6 @@ public function validateRequiredIf($attribute, $value, $parameters) { $this->requireParameterCount(2, $parameters, 'required_if'); - if (! Arr::has($this->data, $parameters[0])) { - return true; - } - [$values, $other] = $this->parseDependentRuleParameters($parameters); if (in_array($other, $values, is_bool($other) || is_null($other))) { @@ -1612,10 +1608,6 @@ public function validateExcludeIf($attribute, $value, $parameters) { $this->requireParameterCount(2, $parameters, 'exclude_if'); - if (! Arr::has($this->data, $parameters[0])) { - return true; - } - [$values, $other] = $this->parseDependentRuleParameters($parameters); return ! in_array($other, $values, is_bool($other) || is_null($other));