[10.x] Use faster hash algorithm (xxh128) #45371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KennedyTedesco some benchmarks are always appreciated when sending in performance PRs. |
|
Specifically, about
Reference: https://php.watch/articles/php-hash-benchmark I haven't benchmarked the View component, and I don't have a starting point to do it yet (tips are welcome! :D). I'm willing to work on this by the end of the week. |
|
I think this seems OK to me. The only breaking change I could think of would be if a third-party package was depending on the file names being in the exact format of a SHA-1 hash. |
|
I agree. Worth to document this in future release notes. Since we're working on a major version, I think we're fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are requiring PHP 8.1 or higher, what about starting to use xxh128 hashing on views?
Are there any further implications to consider with this change that I'm not aware of?
Twig has made this move successfully. See the following references for more information:
twigphp/Twig#3588
They are also using it for http cache store key:
symfony/symfony#47094
About the hash:
https://php.watch/versions/8.1/xxHash