Merge pull request rubocop#707 from rubocop-hq/fix-create-list-cop

Maxim Krizhanovsky · web-flow · commit b3507f7922b8 · 2018-10-19T22:31:27.000+03:00
Fix rubocop#702: don't flag n.times block with an argument
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Master (Unreleased)
 
+* `FactoryBot/CreateList` now ignores `times` blocks with an argument. ([@Darhazer][])
+
 ## 1.30.0 (2018-10-08)
 
 * Add config to `RSpec/VerifiedDoubles` to enforcement of verification on unnamed doubles. ([@BrentWheeldon][])
diff --git a/lib/rubocop/cop/rspec/factory_bot/create_list.rb b/lib/rubocop/cop/rspec/factory_bot/create_list.rb
@@ -30,9 +30,10 @@ class CreateList < Cop
           MSG_CREATE_LIST = 'Prefer create_list.'.freeze
           MSG_N_TIMES = 'Prefer %<number>s.times.'.freeze
 
-          def_node_matcher :n_times_block?, <<-PATTERN
+          def_node_matcher :n_times_block_without_arg?, <<-PATTERN
             (block
               (send (int _) :times)
+              (args)
               ...
             )
           PATTERN
@@ -47,7 +48,7 @@ class CreateList < Cop
 
           def on_block(node)
             return unless style == :create_list
-            return unless n_times_block?(node)
+            return unless n_times_block_without_arg?(node)
             return unless contains_only_factory?(node.body)
 
             add_offense(node.send_node,
diff --git a/spec/rubocop/cop/rspec/factory_bot/create_list_spec.rb b/spec/rubocop/cop/rspec/factory_bot/create_list_spec.rb
@@ -41,10 +41,9 @@
       RUBY
     end
 
-    it 'flags n.times with argument' do
-      expect_offense(<<-RUBY)
+    it 'ignores n.times with argument' do
+      expect_no_offenses(<<-RUBY)
         3.times { |n| create :user, created_at: n.days.ago }
-        ^^^^^^^ Prefer create_list.
       RUBY
     end
 
