Merge pull request rubocop#609 from rubocop-rspec/fix-feature-methods

Darhazer · web-flow · commit cb23a0f5dca8 · 2018-05-14T15:43:56.000+03:00
Fix Capybara/FeatureMethods not working when there is require before the spec
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Master (Unreleased)
 
 * Fix false positive in `RSpec/EmptyExampleGroup` cop when methods named like a RSpec method are used.  ([@Darhazer][])
+* Fix `Capybara/FeatureMethods` not working when there is require before the spec. ([@Darhazer][])
 
 ## 1.25.1 (2018-04-10)
 
diff --git a/lib/rubocop/cop/rspec/capybara/feature_methods.rb b/lib/rubocop/cop/rspec/capybara/feature_methods.rb
@@ -66,7 +66,7 @@ class FeatureMethods < Cop
           PATTERN
 
           def on_block(node)
-            return unless spec?(root_node)
+            return unless inside_spec?(node)
 
             feature_method(node) do |send_node, match|
               next if enabled?(match)
@@ -87,8 +87,19 @@ def autocorrect(node)
 
           private
 
-          def root_node
-            processed_source.ast
+          def inside_spec?(node)
+            return spec?(node) if root_node?(node)
+
+            root = node.ancestors.find { |parent| root_node?(parent) }
+            spec?(root)
+          end
+
+          def root_node?(node)
+            node.parent.nil? || root_with_siblings?(node.parent)
+          end
+
+          def root_with_siblings?(node)
+            node.begin_type? && node.parent.nil?
           end
 
           def enabled?(method_name)
diff --git a/spec/rubocop/cop/rspec/capybara/feature_methods_spec.rb b/spec/rubocop/cop/rspec/capybara/feature_methods_spec.rb
@@ -76,6 +76,15 @@
     RUBY
   end
 
+  it 'allows includes before the spec' do
+    expect_offense(<<-RUBY)
+      require 'rails_helper'
+
+      RSpec.feature 'Foo' do; end
+            ^^^^^^^ Use `describe` instead of `feature`.
+    RUBY
+  end
+
   context 'with configured `EnabledMethods`' do
     let(:cop_config) { { 'EnabledMethods' => %w[feature] } }
 
