Fix Style/MutableConstant; disable AlignHash

bquorning · bquorning · commit cb4984fc84c7 · 2018-11-01T13:18:28.000+01:00
I disagree with the recent changes in AlignHash, so a combination of `key` and `table` styles is no longer allowed. The issue is very well described in rubocop/rubocop#6410 .
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -9,6 +9,10 @@ AllCops:
     - 'tmp/**/*'
     - 'spec/smoke_tests/**/*.rb'
 
+# See https://github.com/rubocop-hq/rubocop/issues/6410
+Layout/AlignHash:
+  Enabled: false
+
 Metrics/BlockLength:
   Exclude:
     - rubocop-rspec.gemspec
diff --git a/lib/rubocop/cop/rspec/example_wording.rb b/lib/rubocop/cop/rspec/example_wording.rb
@@ -33,8 +33,8 @@ class ExampleWording < Cop
         MSG_SHOULD = 'Do not use should when describing your tests.'.freeze
         MSG_IT     = "Do not repeat 'it' when describing your tests.".freeze
 
-        SHOULD_PREFIX = /\Ashould(?:n't)?\b/i
-        IT_PREFIX     = /\Ait /i
+        SHOULD_PREFIX = /\Ashould(?:n't)?\b/i.freeze
+        IT_PREFIX     = /\Ait /i.freeze
 
         def_node_matcher(
           :it_description,
diff --git a/lib/rubocop/rspec/config_formatter.rb b/lib/rubocop/rspec/config_formatter.rb
@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Builds a YAML config file from two config hashes
     class ConfigFormatter
-      NAMESPACES = /^(RSpec|Capybara|FactoryBot|Rails)/
+      NAMESPACES = /^(RSpec|Capybara|FactoryBot|Rails)/.freeze
       STYLE_GUIDE_BASE_URL = 'http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/'.freeze
 
       def initialize(config, descriptions)
diff --git a/lib/rubocop/rspec/wording.rb b/lib/rubocop/rspec/wording.rb
@@ -4,10 +4,10 @@ module RuboCop
   module RSpec
     # RSpec example wording rewriter
     class Wording
-      SHOULDNT_PREFIX    = /\Ashould(?:n't| not)\b/i
-      SHOULDNT_BE_PREFIX = /#{SHOULDNT_PREFIX} be\b/i
-      ES_SUFFIX_PATTERN  = /(?:o|s|x|ch|sh|z)\z/i
-      IES_SUFFIX_PATTERN = /[^aeou]y\z/i
+      SHOULDNT_PREFIX    = /\Ashould(?:n't| not)\b/i.freeze
+      SHOULDNT_BE_PREFIX = /#{SHOULDNT_PREFIX} be\b/i.freeze
+      ES_SUFFIX_PATTERN  = /(?:o|s|x|ch|sh|z)\z/i.freeze
+      IES_SUFFIX_PATTERN = /[^aeou]y\z/i.freeze
 
       def initialize(text, ignore:, replace:)
         @text         = text
