test: migrate some tests from assert to jest expect (typescript-eslint#1437)

armano2 · bradzacher · commit d8445d54fdb7 · 2020-01-12T19:55:13.000-08:00
diff --git a/packages/eslint-plugin/tests/util.test.ts b/packages/eslint-plugin/tests/util.test.ts
@@ -1,5 +1,3 @@
-import assert from 'assert';
-
 import * as util from '../src/util';
 
 describe('isDefinitionFile', () => {
@@ -20,21 +18,21 @@ describe('isDefinitionFile', () => {
     ];
 
     invalid.forEach(f => {
-      assert.strictEqual(util.isDefinitionFile(f), false);
+      expect(util.isDefinitionFile(f)).toStrictEqual(false);
     });
   });
 
   it('returns true for definition files', () => {
     const valid = ['test.d.ts', 'test.d.tsx', 'test.D.TS', 'test.D.TSX'];
 
     valid.forEach(f => {
-      assert.strictEqual(util.isDefinitionFile(f), true);
+      expect(util.isDefinitionFile(f)).toStrictEqual(true);
     });
   });
 });
 
 describe('upperCaseFirst', () => {
   it('upper cases first', () => {
-    assert.strictEqual(util.upperCaseFirst('hello'), 'Hello');
+    expect(util.upperCaseFirst('hello')).toStrictEqual('Hello');
   });
 });
diff --git a/packages/experimental-utils/tests/eslint-utils/applyDefault.test.ts b/packages/experimental-utils/tests/eslint-utils/applyDefault.test.ts
@@ -1,40 +1,34 @@
-import assert from 'assert';
-
 import * as util from '../../src/eslint-utils/applyDefault';
 
 describe('applyDefault', () => {
   it('returns a clone of the default if no options given', () => {
-    const defaults = [
-      {
-        prop: 'setting',
-      },
-    ];
+    const defaults = [{ prop: 'setting' }];
     const user = null;
     const result = util.applyDefault(defaults, user);
 
-    assert.deepStrictEqual(result, defaults);
-    assert.notStrictEqual(result, defaults);
+    expect(result).toStrictEqual(defaults);
+    expect(result).not.toBe(defaults);
   });
 
   it('returns applies a deepMerge to each element in the array', () => {
-    const defaults = [
+    const defaults: Record<string, string>[] = [
       {
         prop: 'setting1',
         other: 'other',
       },
       {
         prop: 'setting2',
       },
-    ] as Record<string, string>[];
-    const user = [
+    ];
+    const user: Record<string, string>[] = [
       {
         prop: 'new',
         other: 'something',
       },
-    ] as Record<string, string>[];
+    ];
     const result = util.applyDefault(defaults, user);
 
-    assert.deepStrictEqual(result, [
+    expect(result).toStrictEqual([
       {
         prop: 'new',
         other: 'something',
@@ -43,16 +37,16 @@ describe('applyDefault', () => {
         prop: 'setting2',
       },
     ]);
-    assert.notStrictEqual(result, defaults);
-    assert.notStrictEqual(result, user);
+    expect(result).not.toBe(defaults);
+    expect(result).not.toBe(user);
   });
 
   it('returns a brand new array', () => {
     const defaults: undefined[] = [];
     const user: undefined[] = [];
     const result = util.applyDefault(defaults, user);
 
-    assert.notStrictEqual(result, defaults);
-    assert.notStrictEqual(result, user);
+    expect(result).not.toBe(defaults);
+    expect(result).not.toBe(user);
   });
 });
diff --git a/packages/experimental-utils/tests/eslint-utils/deepMerge.test.ts b/packages/experimental-utils/tests/eslint-utils/deepMerge.test.ts
@@ -1,5 +1,3 @@
-import assert from 'assert';
-
 import * as util from '../../src/eslint-utils/deepMerge';
 
 describe('deepMerge', () => {
@@ -8,8 +6,8 @@ describe('deepMerge', () => {
     const b = {};
     const result = util.deepMerge(a, b);
 
-    assert.notStrictEqual(result, a);
-    assert.notStrictEqual(result, b);
+    expect(result).not.toBe(a);
+    expect(result).not.toBe(b);
   });
 
   it('deeply merges objects', () => {
@@ -40,7 +38,7 @@ describe('deepMerge', () => {
       },
     };
 
-    assert.deepStrictEqual(util.deepMerge(a, b), Object.assign({}, a, b));
+    expect(util.deepMerge(a, b)).toStrictEqual(Object.assign({}, a, b));
   });
 
   it('deeply overwrites properties in the first one with the second', () => {
@@ -55,6 +53,6 @@ describe('deepMerge', () => {
       },
     };
 
-    assert.deepStrictEqual(util.deepMerge(a, b), b);
+    expect(util.deepMerge(a, b)).toStrictEqual(b);
   });
 });
