From 3ac806b9340cea60a754475e1d5afba5d1da6d20 Mon Sep 17 00:00:00 2001
From: anutosh491 <andersonbhat491@gmail.com>
Date: Sat, 12 Aug 2023 09:01:24 +0530
Subject: [PATCH 1/3] Added support for freeing variables in the ASR symbolic
 pass

---
 src/libasr/pass/replace_symbolic.cpp | 60 +++++++++++++++++++++++++++-
 1 file changed, 59 insertions(+), 1 deletion(-)

diff --git a/src/libasr/pass/replace_symbolic.cpp b/src/libasr/pass/replace_symbolic.cpp
index b30fca76a3..6b1c0bdae5 100644
--- a/src/libasr/pass/replace_symbolic.cpp
+++ b/src/libasr/pass/replace_symbolic.cpp
@@ -54,6 +54,7 @@ class ReplaceSymbolicVisitor : public PassUtils::PassVisitor<ReplaceSymbolicVisi
         ASR::Function_t &xx = const_cast<ASR::Function_t&>(x);
         SymbolTable* current_scope_copy = this->current_scope;
         this->current_scope = xx.m_symtab;
+        SymbolTable* module_scope = this->current_scope->parent;
         for (auto &item : x.m_symtab->get_scope()) {
             if (ASR::is_a<ASR::Variable_t>(*item.second)) {
                 ASR::Variable_t *s = ASR::down_cast<ASR::Variable_t>(item.second);
@@ -75,6 +76,31 @@ class ReplaceSymbolicVisitor : public PassUtils::PassVisitor<ReplaceSymbolicVisi
         xx.n_dependencies = function_dependencies.size();
         xx.m_dependencies = function_dependencies.p;
         this->current_scope = current_scope_copy;
+
+        // freeing out variables
+        std::string new_name = "basic_free_stack";
+        ASR::symbol_t* basic_free_stack_sym = module_scope->get_symbol(new_name);
+        Vec<ASR::stmt_t*> func_body;
+        func_body.n = 0;
+        func_body.reserve(al, 1);
+        for (size_t i = 0; i < xx.n_body; i++) {
+            func_body.push_back(al, xx.m_body[i]);
+        }
+
+        for (ASR::symbol_t* symbol : symbolic_vars) {
+            Vec<ASR::call_arg_t> call_args;
+            call_args.reserve(al, 1);
+            ASR::call_arg_t call_arg;
+            call_arg.loc = xx.base.base.loc;
+            call_arg.m_value = ASRUtils::EXPR(ASR::make_Var_t(al, xx.base.base.loc, symbol));
+            call_args.push_back(al, call_arg);
+            ASR::stmt_t* stmt = ASRUtils::STMT(ASR::make_SubroutineCall_t(al, xx.base.base.loc, basic_free_stack_sym,
+                basic_free_stack_sym, call_args.p, call_args.n, nullptr));
+            func_body.push_back(al, stmt);
+        }
+
+        xx.n_body = func_body.size();
+        xx.m_body = func_body.p;
     }
 
     void visit_Variable(const ASR::Variable_t& x) {
@@ -132,6 +158,38 @@ class ReplaceSymbolicVisitor : public PassUtils::PassVisitor<ReplaceSymbolicVisi
                 module_scope->add_symbol(new_name, new_symbol);
             }
 
+            new_name = "basic_free_stack";
+            symbolic_dependencies.push_back(new_name);
+            if (!module_scope->get_symbol(new_name)) {
+                std::string header = "symengine/cwrapper.h";
+                SymbolTable *fn_symtab = al.make_new<SymbolTable>(module_scope);
+
+                Vec<ASR::expr_t*> args;
+                {
+                    args.reserve(al, 1);
+                    ASR::symbol_t *arg = ASR::down_cast<ASR::symbol_t>(ASR::make_Variable_t(
+                        al, xx.base.base.loc, fn_symtab, s2c(al, "x"), nullptr, 0, ASR::intentType::In,
+                        nullptr, nullptr, ASR::storage_typeType::Default, type1, nullptr,
+                        ASR::abiType::BindC, ASR::Public, ASR::presenceType::Required, true));
+                    fn_symtab->add_symbol(s2c(al, "x"), arg);
+                    args.push_back(al, ASRUtils::EXPR(ASR::make_Var_t(al, xx.base.base.loc, arg)));
+                }
+
+                Vec<ASR::stmt_t*> body;
+                body.reserve(al, 1);
+
+                Vec<char *> dep;
+                dep.reserve(al, 1);
+
+                ASR::asr_t* new_subrout = ASRUtils::make_Function_t_util(al, xx.base.base.loc,
+                    fn_symtab, s2c(al, new_name), dep.p, dep.n, args.p, args.n, body.p, body.n,
+                    nullptr, ASR::abiType::BindC, ASR::accessType::Public,
+                    ASR::deftypeType::Interface, s2c(al, new_name), false, false, false,
+                    false, false, nullptr, 0, false, false, false, s2c(al, header));
+                ASR::symbol_t *new_symbol = ASR::down_cast<ASR::symbol_t>(new_subrout);
+                module_scope->add_symbol(new_name, new_symbol);
+            }
+
             ASR::symbol_t* var_sym = current_scope->get_symbol(var_name);
             ASR::symbol_t* placeholder_sym = current_scope->get_symbol(placeholder);
             ASR::expr_t* target1 = ASRUtils::EXPR(ASR::make_Var_t(al, xx.base.base.loc, placeholder_sym));
@@ -154,7 +212,7 @@ class ReplaceSymbolicVisitor : public PassUtils::PassVisitor<ReplaceSymbolicVisi
                 type1, nullptr));
 
             // statement 4
-            ASR::symbol_t* basic_new_stack_sym = module_scope->get_symbol(new_name);
+            ASR::symbol_t* basic_new_stack_sym = module_scope->get_symbol("basic_new_stack");
             Vec<ASR::call_arg_t> call_args;
             call_args.reserve(al, 1);
             ASR::call_arg_t call_arg;

From a1b9a8b082428a98f06bce0428a0512c66bef459 Mon Sep 17 00:00:00 2001
From: anutosh491 <andersonbhat491@gmail.com>
Date: Sat, 12 Aug 2023 11:22:06 +0530
Subject: [PATCH 2/3] Fixed failing tests

---
 integration_tests/symbolics_08.py    | 5 +++++
 src/libasr/pass/replace_symbolic.cpp | 1 +
 2 files changed, 6 insertions(+)

diff --git a/integration_tests/symbolics_08.py b/integration_tests/symbolics_08.py
index c360b60f37..15e010d160 100644
--- a/integration_tests/symbolics_08.py
+++ b/integration_tests/symbolics_08.py
@@ -5,6 +5,10 @@
 def basic_new_stack(x: CPtr) -> None:
     pass
 
+@ccall(header="symengine/cwrapper.h", c_shared_lib="symengine", c_shared_lib_path=f"{os.environ['CONDA_PREFIX']}/lib")
+def basic_free_stack(x: CPtr) -> None:
+    pass
+
 @ccall(header="symengine/cwrapper.h", c_shared_lib="symengine", c_shared_lib_path=f"{os.environ['CONDA_PREFIX']}/lib")
 def basic_const_pi(x: CPtr) -> None:
     pass
@@ -22,5 +26,6 @@ def main0():
     s: str = basic_str(x)
     print(s)
     assert s == "pi"
+    basic_free_stack(x)
 
 main0()
\ No newline at end of file
diff --git a/src/libasr/pass/replace_symbolic.cpp b/src/libasr/pass/replace_symbolic.cpp
index 6b1c0bdae5..649bce4985 100644
--- a/src/libasr/pass/replace_symbolic.cpp
+++ b/src/libasr/pass/replace_symbolic.cpp
@@ -101,6 +101,7 @@ class ReplaceSymbolicVisitor : public PassUtils::PassVisitor<ReplaceSymbolicVisi
 
         xx.n_body = func_body.size();
         xx.m_body = func_body.p;
+        symbolic_vars.clear();
     }
 
     void visit_Variable(const ASR::Variable_t& x) {

From 5da926de6e9ba177c80863c19c17cce415bde094 Mon Sep 17 00:00:00 2001
From: anutosh491 <andersonbhat491@gmail.com>
Date: Sat, 12 Aug 2023 19:12:02 +0530
Subject: [PATCH 3/3] addressed suggested change

---
 src/libasr/pass/replace_symbolic.cpp | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/libasr/pass/replace_symbolic.cpp b/src/libasr/pass/replace_symbolic.cpp
index 649bce4985..f0cda46468 100644
--- a/src/libasr/pass/replace_symbolic.cpp
+++ b/src/libasr/pass/replace_symbolic.cpp
@@ -81,11 +81,7 @@ class ReplaceSymbolicVisitor : public PassUtils::PassVisitor<ReplaceSymbolicVisi
         std::string new_name = "basic_free_stack";
         ASR::symbol_t* basic_free_stack_sym = module_scope->get_symbol(new_name);
         Vec<ASR::stmt_t*> func_body;
-        func_body.n = 0;
-        func_body.reserve(al, 1);
-        for (size_t i = 0; i < xx.n_body; i++) {
-            func_body.push_back(al, xx.m_body[i]);
-        }
+        func_body.from_pointer_n_copy(al, xx.m_body, xx.n_body);
 
         for (ASR::symbol_t* symbol : symbolic_vars) {
             Vec<ASR::call_arg_t> call_args;