Add --no-coverage to all phpspec commands - fixes #30

ek9 · ek9 · commit 82495f532663 · 2018-03-21T12:30:21.000Z
diff --git a/src/CodeCoverageExtension.php b/src/CodeCoverageExtension.php
@@ -24,12 +24,9 @@ class CodeCoverageExtension implements \PhpSpec\Extension
     public function load(ServiceContainer $container, array $params = [])
     {
         foreach ($container->getByTag('console.commands') as $command) {
-            if ($command->getName() == 'run') {
-                $command->addOption('no-coverage', null, InputOption::VALUE_NONE, 'Skip code coverage generation');
-            }
+            $command->addOption('no-coverage', null, InputOption::VALUE_NONE, 'Skip code coverage generation');
         }
 
-
         $container->define('code_coverage.filter', function () {
             return new Filter();
         });
@@ -107,7 +104,7 @@ public function load(ServiceContainer $container, array $params = [])
 
             $skipCoverage = false;
             $input = $container->get('console.input');
-            if (!$input->hasOption('no-coverage') || $input->getOption('no-coverage')) {
+            if ($input->hasOption('no-coverage') && $input->getOption('no-coverage')) {
                 $skipCoverage = true;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -24,12 +24,9 @@ class CodeCoverageExtension implements \PhpSpec\Extension`
`24`	`24`	`public function load(ServiceContainer $container, array $params = [])`
`25`	`25`	`{`
`26`	`26`	`foreach ($container->getByTag('console.commands') as $command) {`
`27`		`- if ($command->getName() == 'run') {`
`28`		`- $command->addOption('no-coverage', null, InputOption::VALUE_NONE, 'Skip code coverage generation');`
`29`		`- }`
	`27`	`+ $command->addOption('no-coverage', null, InputOption::VALUE_NONE, 'Skip code coverage generation');`
`30`	`28`	`}`
`31`	`29`
`32`		`-`
`33`	`30`	`$container->define('code_coverage.filter', function () {`
`34`	`31`	`return new Filter();`
`35`	`32`	`});`
`@@ -107,7 +104,7 @@ public function load(ServiceContainer $container, array $params = [])`
`107`	`104`
`108`	`105`	`$skipCoverage = false;`
`109`	`106`	`$input = $container->get('console.input');`
`110`		`- if (!$input->hasOption('no-coverage') \|\| $input->getOption('no-coverage')) {`
	`107`	`+ if ($input->hasOption('no-coverage') && $input->getOption('no-coverage')) {`
`111`	`108`	`$skipCoverage = true;`
`112`	`109`	`}`
`113`	`110`