From d5042cf839d21af49b296531ae1e19a84d7471f0 Mon Sep 17 00:00:00 2001 From: Bruce Date: Wed, 21 Mar 2018 12:05:30 +0100 Subject: [PATCH 1/3] Fix missing check for 'no-coverage' option Executing 'bin/phpspec describe ...' gives the following error : "The 'no-coverage' option does not exist." --- src/CodeCoverageExtension.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CodeCoverageExtension.php b/src/CodeCoverageExtension.php index e275c01..6cef0b5 100644 --- a/src/CodeCoverageExtension.php +++ b/src/CodeCoverageExtension.php @@ -107,7 +107,7 @@ public function load(ServiceContainer $container, array $params = []) $skipCoverage = false; $input = $container->get('console.input'); - if ($input->getOption('no-coverage')) { + if (!$input->hasOption('no-coverage') || $input->getOption('no-coverage')) { $skipCoverage = true; } From 82495f5326638f3bdc43c0a878df3965feffb032 Mon Sep 17 00:00:00 2001 From: ek9 Date: Wed, 21 Mar 2018 12:11:23 +0000 Subject: [PATCH 2/3] Add --no-coverage to all phpspec commands - fixes #30 --- src/CodeCoverageExtension.php | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/CodeCoverageExtension.php b/src/CodeCoverageExtension.php index 6cef0b5..03a14cc 100644 --- a/src/CodeCoverageExtension.php +++ b/src/CodeCoverageExtension.php @@ -24,12 +24,9 @@ class CodeCoverageExtension implements \PhpSpec\Extension public function load(ServiceContainer $container, array $params = []) { foreach ($container->getByTag('console.commands') as $command) { - if ($command->getName() == 'run') { - $command->addOption('no-coverage', null, InputOption::VALUE_NONE, 'Skip code coverage generation'); - } + $command->addOption('no-coverage', null, InputOption::VALUE_NONE, 'Skip code coverage generation'); } - $container->define('code_coverage.filter', function () { return new Filter(); }); @@ -107,7 +104,7 @@ public function load(ServiceContainer $container, array $params = []) $skipCoverage = false; $input = $container->get('console.input'); - if (!$input->hasOption('no-coverage') || $input->getOption('no-coverage')) { + if ($input->hasOption('no-coverage') && $input->getOption('no-coverage')) { $skipCoverage = true; } From ebb7777fcc64173f5b13eff7b2579a63f58fb0ad Mon Sep 17 00:00:00 2001 From: ek9 Date: Wed, 21 Mar 2018 12:12:49 +0000 Subject: [PATCH 3/3] CHANGELOG v4.1.2 --- CHANGELOG.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6208f6b..32e5246 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,12 @@ documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). +## [4.1.2] - 2018-03-21 + +- Fix `--no-coverage` option introducing errors when running non `run` commands. +- `--no-coverage` option is now available to all phpspec commands (not only + `run`). (#30) + ## [4.1.1] - 2018-03-19 - Added `--no-coverage` option which can skip code coverage generation during @@ -80,6 +86,7 @@ as [leanphp/phpspec-code-coverage][0]. - Support configuring a blacklist of files to be excluded from code coverage reports (`blaclist_files` option). +[4.1.2]: https://github.com/leanphp/phpspec-code-coverage/releases/tag/v4.1.2 [4.1.1]: https://github.com/leanphp/phpspec-code-coverage/releases/tag/v4.1.1 [4.1.0]: https://github.com/leanphp/phpspec-code-coverage/releases/tag/v4.1.0 [4.0.0]: https://github.com/leanphp/phpspec-code-coverage/releases/tag/v4.0.0