Add some boundaries for them errors

Michelle Tilley · Michelle Tilley · commit 414d7ac1be1e · 2017-09-15T14:42:09.000-07:00
diff --git a/lib/controllers/file-patch-controller.js b/lib/controllers/file-patch-controller.js
@@ -9,6 +9,7 @@ import {autobind} from 'core-decorators';
 
 import Switchboard from '../switchboard';
 import FilePatchView from '../views/file-patch-view';
+import ErrorBoundary from '../views/error-boundary';
 import ModelObserver from '../models/model-observer';
 import FilePatch from '../models/file-patch';
 
@@ -171,6 +172,10 @@ export default class FilePatchController extends React.Component {
   }
 
   render() {
+    return <ErrorBoundary>{this.renderDetails()}</ErrorBoundary>;
+  }
+
+  renderDetails() {
     const hunks = this.state.filePatch ? this.state.filePatch.getHunks() : [];
     const repository = this.repositoryObserver.getActiveModel();
     if (repository.isUndetermined() || repository.isLoading()) {
diff --git a/lib/controllers/github-tab-controller.js b/lib/controllers/github-tab-controller.js
@@ -6,6 +6,7 @@ import yubikiri from 'yubikiri';
 import RemotePrController from './remote-pr-controller';
 import GithubLoginModel from '../models/github-login-model';
 import ObserveModel from '../views/observe-model';
+import ErrorBoundary from '../views/error-boundary';
 import {RemotePropType} from '../prop-types';
 
 class RemoteSelector extends React.Component {
@@ -70,9 +71,11 @@ export default class GithubTabController extends React.Component {
 
   render() {
     return (
-      <ObserveModel model={this.props.repository} fetchData={this.fetchModelData}>
-        {data => { return data ? this.renderWithData(data) : null; } }
-      </ObserveModel>
+      <ErrorBoundary>
+        <ObserveModel model={this.props.repository} fetchData={this.fetchModelData}>
+          {data => { return data ? this.renderWithData(data) : null; } }
+        </ObserveModel>
+      </ErrorBoundary>
     );
   }
 
