Merge pull request #6931 from libgit2/ethomson/v1.8.3

ethomson · web-flow · commit 3353f78e8e86 · 2024-10-26T20:03:57.000+01:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -6,7 +6,7 @@
 
 cmake_minimum_required(VERSION 3.5.1)
 
-project(libgit2 VERSION "1.8.1" LANGUAGES C)
+project(libgit2 VERSION "1.8.3" LANGUAGES C)
 
 # Add find modules to the path
 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${PROJECT_SOURCE_DIR}/cmake")
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -1,3 +1,42 @@
+v1.8.3
+------
+
+This release fixes a bug introduced in v1.8.1 for users of the legacy
+[Node.js http-parser](https://github.com/nodejs/http-parser)
+dependency.
+
+## What's Changed
+
+### Bug fixes
+
+* http: Backport on_status initialize fix for http-parser by @ethomson in https://github.com/libgit2/libgit2/pull/6931
+
+v1.8.2
+------
+
+This release reverts a const-correctness change introduced in
+v1.8.0 for the `git_commit_create` functions. We now retain the
+const-behavior for the `commits` arguments from prior to v1.8.0.
+
+This change was meant to resolve compatibility issues with bindings
+and downstream users.
+
+## What's Changed
+
+### New features
+
+* Introduce a stricter debugging allocator for testing by @ethomson in https://github.com/libgit2/libgit2/pull/6811
+
+### Bug fixes
+
+* Fix constness issue introduced in #6716 by @ethomson in https://github.com/libgit2/libgit2/pull/6829
+
+### Build and CI improvements
+
+* README: add experimental builds to ci table by @ethomson in https://github.com/libgit2/libgit2/pull/6816
+
+**Full Changelog**: https://github.com/libgit2/libgit2/compare/v1.8.1...v1.8.2
+
 v1.8.1
 ------
 
diff --git a/include/git2/version.h b/include/git2/version.h
@@ -11,7 +11,7 @@
  * The version string for libgit2.  This string follows semantic
  * versioning (v2) guidelines.
  */
-#define LIBGIT2_VERSION        "1.8.1"
+#define LIBGIT2_VERSION        "1.8.3"
 
 /** The major version number for this version of libgit2. */
 #define LIBGIT2_VER_MAJOR      1
@@ -20,7 +20,7 @@
 #define LIBGIT2_VER_MINOR      8
 
 /** The revision ("teeny") version number for this version of libgit2. */
-#define LIBGIT2_VER_REVISION   1
+#define LIBGIT2_VER_REVISION   3
 
 /** The Windows DLL patch number for this version of libgit2. */
 #define LIBGIT2_VER_PATCH      0
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "libgit2",
-  "version": "1.8.1",
+  "version": "1.8.3",
   "repo": "https://github.com/libgit2/libgit2",
   "description": " A cross-platform, linkable library implementation of Git that you can use in your application.",
   "install": "mkdir build && cd build && cmake .. && cmake --build ."
diff --git a/src/libgit2/transports/httpparser.c b/src/libgit2/transports/httpparser.c
@@ -71,6 +71,8 @@ size_t git_http_parser_execute(
 {
 	struct http_parser_settings settings_proxy;
 
+	memset(&settings_proxy, 0, sizeof(struct http_parser_settings));
+
 	settings_proxy.on_message_begin = parser->settings.on_message_begin ? on_message_begin : NULL;
 	settings_proxy.on_url = parser->settings.on_url ? on_url : NULL;
 	settings_proxy.on_header_field = parser->settings.on_header_field ? on_header_field : NULL;

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "libgit2",`
`3`		`- "version": "1.8.1",`
	`3`	`+ "version": "1.8.3",`
`4`	`4`	`"repo": "https://github.com/libgit2/libgit2",`
`5`	`5`	`"description": " A cross-platform, linkable library implementation of Git that you can use in your application.",`
`6`	`6`	`"install": "mkdir build && cd build && cmake .. && cmake --build ."`
Original file line number	Diff line number	Diff line change
`@@ -71,6 +71,8 @@ size_t git_http_parser_execute(`
`71`	`71`	`{`
`72`	`72`	`struct http_parser_settings settings_proxy;`
`73`	`73`
	`74`	`+ memset(&settings_proxy, 0, sizeof(struct http_parser_settings));`
	`75`	`+`
`74`	`76`	`settings_proxy.on_message_begin = parser->settings.on_message_begin ? on_message_begin : NULL;`
`75`	`77`	`settings_proxy.on_url = parser->settings.on_url ? on_url : NULL;`
`76`	`78`	`settings_proxy.on_header_field = parser->settings.on_header_field ? on_header_field : NULL;`