tests: fix compiler warning if tracing is disabled

pks-t · pks-t · commit 3feda6a239ce · 2019-11-28T14:48:12.000+01:00
If building libgit2's test suite with tracing disabled, then the
compiler will emit a warning due to the unused `message_prefix`
function. Fix the issue by wrapping the whole file into ifdef's for
`GIT_TRACE` and providing separate empty function implementations for
both `cl_global_trace_register` and `cl_global_trace_disable`.
diff --git a/tests/clar_libgit2_trace.c b/tests/clar_libgit2_trace.c
@@ -1,9 +1,10 @@
+#if defined(GIT_TRACE)
+
 #include "clar_libgit2.h"
 #include "clar_libgit2_trace.h"
 #include "clar_libgit2_timer.h"
 #include "trace.h"
 
-
 struct method {
 	const char *name;
 	void (*git_trace_cb)(git_trace_level_t level, const char *msg);
@@ -32,7 +33,6 @@ static const char *message_prefix(git_trace_level_t level)
 	}
 }
 
-#if defined(GIT_TRACE)
 static void _git_trace_cb__printf(git_trace_level_t level, const char *msg)
 {
 	printf("%s%s\n", message_prefix(level), msg);
@@ -225,15 +225,11 @@ void _cl_trace_cb__event_handler(
 	}
 }
 
-#endif /*GIT_TRACE*/
-
 /**
  * Setup/Enable git_trace() based upon settings user's environment.
- *
  */
 void cl_global_trace_register(void)
 {
-#if defined(GIT_TRACE)
 	if (!s_trace_loaded)
 		_load_trace_params();
 
@@ -246,7 +242,6 @@ void cl_global_trace_register(void)
 
 	git_trace_set(s_trace_level, s_trace_method->git_trace_cb);
 	cl_trace_register(_cl_trace_cb__event_handler, NULL);
-#endif
 }
 
 /**
@@ -258,7 +253,6 @@ void cl_global_trace_register(void)
  */
 void cl_global_trace_disable(void)
 {
-#if defined(GIT_TRACE)
 	cl_trace_register(NULL, NULL);
 	git_trace_set(GIT_TRACE_NONE, NULL);
 	if (s_trace_method && s_trace_method->close)
@@ -268,5 +262,16 @@ void cl_global_trace_disable(void)
 	 * since we only want to hit the environment variables
 	 * once.
 	 */
-#endif
 }
+
+#else /* GIT_TRACE */
+
+void cl_global_trace_register(void)
+{
+}
+
+void cl_global_trace_disable(void)
+{
+}
+
+#endif /* GIT_TRACE*/
