use giterr_set_str() wherever possible

pranitbauva1997 · pranitbauva1997 · commit 65b78ea3013c · 2016-11-17T01:12:12.000+05:30
`giterr_set()` is used when it is required to format a string, and since
we don't really require it for this case, it is better to stick to
`giterr_set_str()`.

This also suppresses a warning(-Wformat-security) raised by the compiler.

Signed-off-by: Pranit Bauva &lt;pranit.bauva@gmail.com&gt;
diff --git a/src/index.c b/src/index.c
@@ -552,7 +552,7 @@ int git_index_clear(git_index *index)
 
 static int create_index_error(int error, const char *msg)
 {
-	giterr_set(GITERR_INDEX, msg);
+	giterr_set_str(GITERR_INDEX, msg);
 	return error;
 }
 
diff --git a/src/zstream.c b/src/zstream.c
@@ -21,7 +21,7 @@ static int zstream_seterr(git_zstream *zs)
 	if (zs->zerr == Z_MEM_ERROR)
 		giterr_set_oom();
 	else if (zs->z.msg)
-		giterr_set(GITERR_ZLIB, zs->z.msg);
+		giterr_set_str(GITERR_ZLIB, zs->z.msg);
 	else
 		giterr_set(GITERR_ZLIB, "Unknown compression error");
 

Original file line number	Diff line number	Diff line change
`@@ -552,7 +552,7 @@ int git_index_clear(git_index *index)`
`552`	`552`
`553`	`553`	`static int create_index_error(int error, const char *msg)`
`554`	`554`	`{`
`555`		`- giterr_set(GITERR_INDEX, msg);`
	`555`	`+ giterr_set_str(GITERR_INDEX, msg);`
`556`	`556`	`return error;`
`557`	`557`	`}`
`558`	`558`