Add 2 failing tests related to '.' handling

yorah · yorah · commit 8cc723c72481 · 2013-03-18T11:36:58.000+01:00
No files matched. It fails in `workdir_iterator__update_entry`, as it thinks there is a "." (respectively "./subdir") prefix.

I don't understand iterators well enough to propose a correct fix for now (if there needs one). So far, here is what I thought of:
- Should we "compact" the passed pathspecs, in order to remove the "." and ".."?
- Should we have a custom `prefixcomp` function for iterators, that handles "." and ".." differently?
diff --git a/tests-clar/diff/notify.c b/tests-clar/diff/notify.c
@@ -154,6 +154,46 @@ void test_diff_notify__notify_catchall(void)
 	test_notify(searched_pathspecs, 1, expected_matched_pathspecs, 13);
 }
 
+/*void test_diff_notify__notify_catchall3(void)
+{
+	char *searched_pathspecs[] = {
+		"./subdir",
+	};
+	notify_expected expected_matched_pathspecs[] = {
+		{ "subdir/deleted_file", "./subdir" },
+		{ "subdir/modified_file", "./subdir" },
+		{ "subdir/new_file", "./subdir" },
+		{ NULL, NULL }
+	};
+
+	test_notify(searched_pathspecs, 1, expected_matched_pathspecs, 3);
+}
+
+void test_diff_notify__notify_catchall2(void)
+{
+	char *searched_pathspecs[] = {
+		".",
+	};
+	notify_expected expected_matched_pathspecs[] = {
+		{ "file_deleted", "." },
+		{ "ignored_file", "." },
+		{ "modified_file", "." },
+		{ "new_file", "." },
+		{ "\xe8\xbf\x99", "." },
+		{ "staged_changes_file_deleted", "." },
+		{ "staged_changes_modified_file", "." },
+		{ "staged_delete_modified_file", "." },
+		{ "staged_new_file_deleted_file", "." },
+		{ "staged_new_file_modified_file", "." },
+		{ "subdir/deleted_file", "." },
+		{ "subdir/modified_file", "." },
+		{ "subdir/new_file", "." },
+		{ NULL, NULL }
+	};
+
+	test_notify(searched_pathspecs, 1, expected_matched_pathspecs, 13);
+}*/
+
 static int abort_diff(
 	const git_diff_list *diff_so_far,
 	const git_diff_delta *delta_to_add,
