transports: http: set substream as disconnected after closing

pks-t · pks-t · commit dbf654524424 · 2016-08-17T11:07:59.000+02:00
When calling `http_connect` on a subtransport whose stream is already
connected, we first close the stream in case no keep-alive is in use.
When doing so, we do not reset the transport's connection state,
though. Usually, this will do no harm in case the subsequent connect
will succeed. But when the connection fails we are left with a
substransport which is tagged as connected but which has no valid
stream attached.

Fix the issue by resetting the subtransport's connected-state when
closing its stream in `http_connect`.
diff --git a/src/transports/http.c b/src/transports/http.c
@@ -599,6 +599,7 @@ static int http_connect(http_subtransport *t)
 		git_stream_close(t->io);
 		git_stream_free(t->io);
 		t->io = NULL;
+		t->connected = 0;
 	}
 
 	if (t->connection_data.use_ssl) {

Original file line number	Diff line number	Diff line change
`@@ -599,6 +599,7 @@ static int http_connect(http_subtransport *t)`
`599`	`599`	`git_stream_close(t->io);`
`600`	`600`	`git_stream_free(t->io);`
`601`	`601`	`t->io = NULL;`
	`602`	`+ t->connected = 0;`
`602`	`603`	`}`
`603`	`604`
`604`	`605`	`if (t->connection_data.use_ssl) {`