Timeline for release of version 2? #7149
-
|
The release notes of 1.9.0 tease SHA-256 support in version 2:
Since then, 1.9.1 was released. Some downstream projects (rightfully) defer to libgit2 for any timelines on SHA-256, see, e.g. My attempts to find any hints about a potential timeline for version 2 failed, but I have to admit that I am not following development of libgit2 very closely. I would like to kindly ask the developers on whether there is any timeline or not? A gut feeling might be enough. Thanks. |
Beta Was this translation helpful? Give feedback.
Replies: 5 comments 17 replies
-
|
I'd also love to see this happen being downstream with |
Beta Was this translation helpful? Give feedback.
-
|
Git 3.0 is planning on defaulting to sha-256 repositories. I assume they'll give a decent heads-up before that happens. A little shocking, though, that GitHub doesn't even have support for sha-256 yet, when most of its competitors do. |
Beta Was this translation helpful? Give feedback.
-
|
I agree, but "shocking" is an understatement. Only because you brought up that absurdity will I add fuel to the fire. I've been trying to get them to fix this.
There are patches at the action level that would solve this. They've been sitting on them for over a year. Moreover, @bk2204 is the Microsoft employee that both submitted the sha256 patches to git proper and he frequently gives talks about sha256. https://www.youtube.com/watch?v=OidS-YJxjeo (never met them, but I've heard great things about and them and I worked under their old boss -- people revere them like a saint). So they got the best person for the job, and they got patches demonstrably ready with tests to commit. Meanwhile, Microsoft is taking money to kill kids in Gaza with AI and contracting with CIA. I can't help but wonder if we're all insecure for a more pernicious reasons; and, I wouldn't it that all that shocking. |
Beta Was this translation helpful? Give feedback.
-
|
I've heard a problem for the next release this is that @ethomson has gone silent? Is there anyone else that can cut the release? Are there other breaking changes that need to be merged together before 2.0? I personally don't care about breakage at all --- I don't mind if 2.0 is released, then "whoops we need more breaking changes happens", so 3.0, 4.0, etc. are then released in quick succession. I understand if this is the minority view, but I mention it anyways, as it could take some of the pressure off for getting 2.0 "exactly right". |
Beta Was this translation helpful? Give feedback.
-
|
Generally, disagree. People should have time to perfect their craft and product. However, 100% of software development that stalls with patches in the pipeline have made a mistake. Always. That's a philosophical position that I believe is much more firm than agile development. |
Beta Was this translation helpful? Give feedback.
-
|
To be clear, to me, major version churn means that craftsmanship is still possible. It's only the combination of rushing the ship and "can't do 3.0 right away" that inhibits craftsmanship, and that would be bad! |
Beta Was this translation helpful? Give feedback.
-
|
Motivated to create a list of downstream issues that all point to libgit2 supporting sha256 eventually |
Beta Was this translation helpful? Give feedback.
-
|
Actually, that would be great if you can do that! |
Beta Was this translation helpful? Give feedback.
-
Many of them are downstream issues of libgit2 because of rust-lang/git2-rs#1090 |
Beta Was this translation helpful? Give feedback.
-
|
Not open in the repository, but the nushell gstat plugin also doesn't function in sha256 repositories because of its dependence on libgit2 at the moment. Most nushell users with git statuslines can't have them function in sha256 repos, because the majority of them use gstat. |
Beta Was this translation helpful? Give feedback.
-
You're welcome to do that, but what would be more useful is if any - literally just one - of these downstream users tried the SHA256 support and reported anything - literally anything - about whether it works for them, or has issues. If there are people that are suggesting that libgit2 having sha256 support is necessary for them - and they're not doing anything to use the sha256 support - then please encourage them to do so. |
Beta Was this translation helpful? Give feedback.
-
|
@ethomson How does the downstream PR I made look? What would you like to know? |
Beta Was this translation helpful? Give feedback.
-
|
@ethomson has made a lot of progress this year, and merged some of my PR to help the integration in Cargo. Thanks for that!! @ethomson, do you have a timeline to cut a new release, so Cargo/git2-rs can start the integration and experiment? |
Beta Was this translation helpful? Give feedback.
-
|
The SHA256 integration in Cargo is kinda ready rust-lang/cargo#16939 (with lots of helps from |
Beta Was this translation helpful? Give feedback.
-
|
I want to cut v1.9.3 this weekend with the many bug fixes and small features that have accumulated. I want to follow up with v2 in May but there are a few changes that I still want to land. Thanks for your patience! 🙏 |
Beta Was this translation helpful? Give feedback.
-
|
Yay wonderful! |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for the release 🎉🎉🎉 |
Beta Was this translation helpful? Give feedback.
I want to cut v1.9.3 this weekend with the many bug fixes and small features that have accumulated.
I want to follow up with v2 in May but there are a few changes that I still want to land. Thanks for your patience! 🙏