Thanks to visit codestin.com
Credit goes to github.com

Skip to content

testsuite failures without openssl on v0.24.0 #3731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andhe opened this issue Apr 6, 2016 · 4 comments
Closed

testsuite failures without openssl on v0.24.0 #3731

andhe opened this issue Apr 6, 2016 · 4 comments

Comments

@andhe
Copy link
Contributor

andhe commented Apr 6, 2016

Hello!

While trying to update libgit2 in Debian I stumbled upon testsuite failures which only happens when building with openssl disabled (which is how it's been done in Debian to allow GPLv2 projects to use libgit2 without running into OpenSSL licensing issues).

The first problem is reproducible on git master and fixed in #3730

I run into two additional problems after that which I have no idea how they're openssl related:

  1. Failure:
    repo::iterator::unreadable_dir [/build/libgit2-0.24.0/tests/repo/iterator.c:1037]
    Expected function call to fail: git_iterator_advance(&e, i)

  2. Failure:
    status::worktree::unreadable [/build/libgit2-0.24.0/tests/status/worktree.c:1028]
    0 != counts.wrong_status_flags_count
    0 != 1

I can't reproduce these when building git master, but it seems there's been quite some refactoring of the iterators etc going on. Are the above known (fixed) issues? Is there an easy fix I can use with v0.24.0 ? Will a new release come soon?
@ethomson
Copy link
Member

ethomson commented Apr 6, 2016

@andhe I can't reproduce those in v0.24.0. I also can't imagine that they're openssl related - and while there has been iterator refactoring going on, that has happened post-v0.24.0.

I'm not very familiar with the debian packaging build environment, but these tests do things on the filesystem that may not be easily reproducible within a sandboxed environment. For example, are you running the test suite as root?

When you're building & testing master, are you doing it from within the packaging build environment or in a normal setup? Can you test v0.24.0 and see if those tests pass when run in a normal build setup?

@andhe
Copy link
Contributor Author

andhe commented Apr 11, 2016

@ethomson thanks for those hints. It seems the failure only happens while running under "fakeroot". Will investigate further.

@ethomson ethomson mentioned this issue Apr 11, 2016
Merged
@andhe
Copy link
Contributor Author

andhe commented Apr 12, 2016

I've worked around this with a hack that disables fakeroot while running the testsuite in the package building for now. I can confirm the above mentioned commit also fixes the issue when running under fakeroot. Please feel free to close this issue. Thanks for planning v0.24.1!

@ethomson
Copy link
Member

@andhe We just shipped https://github.com/libgit2/libgit2/releases/tag/v0.24.1 for ya - hope this helps. Thanks for maintaining the Debian package! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ethomson @andhe