-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Crash with invalid proxy configuration #5323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Did you check whether this behaviour still exists in current master? We've removed |
I confirm. The issue only exists in 0.28.3. |
Still, because as of latest libgit2sharp is using 0.28.4, the issue affects a PR that would allow libgit2sharp to detect proxy settings libgit2/libgit2sharp#1708 . I'll move the discussion there |
Thanks a lot for confirming! Normally I'd consider backporting, but backporting this particular season doesn't seem feasible to me as there's too many things that've been changed. It's a bit unfortunate, but yeah. We're prorably going to release v0.99 soon-ish anyway, at which point libgit2sharp could upgrade to our newer release. |
libgit 0.28.3
winhttp.c
winhttp_stream_connect
if (proxy_url)
gitno_extract_url_parts
default port not specified
If the configuration contains an URL without a port (as a mistake for example), gitno_extract_url_parts will try to deference the default_port received as argument, that is NULL.
The text was updated successfully, but these errors were encountered: