Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Crash with invalid proxy configuration #5323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seshonaar opened this issue Dec 5, 2019 · 4 comments
Closed

Crash with invalid proxy configuration #5323

seshonaar opened this issue Dec 5, 2019 · 4 comments

Comments

@seshonaar
Copy link

libgit 0.28.3
winhttp.c
winhttp_stream_connect
if (proxy_url)
gitno_extract_url_parts
default port not specified

If the configuration contains an URL without a port (as a mistake for example), gitno_extract_url_parts will try to deference the default_port received as argument, that is NULL.

@pks-t
Copy link
Member

pks-t commented Dec 13, 2019

Did you check whether this behaviour still exists in current master? We've removed gitno_extract_url_parts due to some refactorings in c6ab183 (net: rename gitno_connection_data to git_net_url, 2019-03-11), and we're not passing any default ports anymore. I'd thus expect that this has been implicitly fixed already.

@seshonaar
Copy link
Author

I confirm. The issue only exists in 0.28.3.

@seshonaar
Copy link
Author

Still, because as of latest libgit2sharp is using 0.28.4, the issue affects a PR that would allow libgit2sharp to detect proxy settings libgit2/libgit2sharp#1708 . I'll move the discussion there

@pks-t
Copy link
Member

pks-t commented Dec 14, 2019

Thanks a lot for confirming! Normally I'd consider backporting, but backporting this particular season doesn't seem feasible to me as there's too many things that've been changed. It's a bit unfortunate, but yeah. We're prorably going to release v0.99 soon-ish anyway, at which point libgit2sharp could upgrade to our newer release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants