Thanks to visit codestin.com
Credit goes to github.com

Skip to content

_FILE_OFFSET_BITS=64 breaks tests on 32bit systems #7169

@yelninei

Description

@yelninei

Hello,

I have been tracking down test failures on 32bit systems related to git_fs_path_lstat.

In tests/libgit2/CmakeLists.txt and tests/util/CmakeLists.txt there is both a

add_definitions(-D_FILE_OFFSET_BITS=64)

but the main library might not be compiled with FILE_OFFSET_BITS=64. This then causes a discrepancy as the main library assumes a 32bit stat struct but the tests the stat64 struct.

There is also the GITTEST_FLAKY_STAT environment variable which I cant find any documentation for but the commit that introduced it e7fce1b mentions 32bit arm so this is probably related.

After I removed the FILE_OFFSET_BITS definitions i had no more problems with "flaky" stat tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions