-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Open
Description
Hello,
I have been tracking down test failures on 32bit systems related to git_fs_path_lstat.
In tests/libgit2/CmakeLists.txt and tests/util/CmakeLists.txt there is both a
add_definitions(-D_FILE_OFFSET_BITS=64)but the main library might not be compiled with FILE_OFFSET_BITS=64. This then causes a discrepancy as the main library assumes a 32bit stat struct but the tests the stat64 struct.
There is also the GITTEST_FLAKY_STAT environment variable which I cant find any documentation for but the commit that introduced it e7fce1b mentions 32bit arm so this is probably related.
After I removed the FILE_OFFSET_BITS definitions i had no more problems with "flaky" stat tests.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels