Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Path comparisons on Windows #214

Closed
Closed
@phkelley

Description

@phkelley

For example in Index.cs, BuildRelativePathFrom:

if (!normalizedPath.StartsWith(repo.Info.WorkingDirectory, StringComparison.Ordinal))

This isn't accurate when the platform has a filesystem that is case-insensitive but case-preserving. It can reject a path as not being in the repo when it actually is. But I believe this library is supposed to work on Mono as well, so some kind of ability to switch between Ordinal and OrdinalIgnoreCase is probably going to be necessary.

Just thought I would bring it up. Thanks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions