rugged_diff_line_new does not need an owner.

arthurschreiber · arthurschreiber · commit a88aaf5db6ef · 2014-02-26T22:11:15.000+01:00
We don’t wrap an actual libgit2 object, so we don’t need to keep a
reference to the owning object.
diff --git a/ext/rugged/rugged.h b/ext/rugged/rugged.h
@@ -87,7 +87,7 @@ VALUE rugged_diff_new(VALUE klass, VALUE owner, git_diff *diff);
 VALUE rugged_patch_new(VALUE owner, git_patch *patch);
 VALUE rugged_diff_delta_new(VALUE owner, const git_diff_delta *delta);
 VALUE rugged_diff_hunk_new(VALUE owner, size_t hunk_idx, const git_diff_hunk *hunk, size_t lines_in_hunk);
-VALUE rugged_diff_line_new(VALUE owner, const git_diff_line *line);
+VALUE rugged_diff_line_new(const git_diff_line *line);
 VALUE rb_git_delta_file_fromC(const git_diff_file *file);
 
 void rugged_parse_diff_options(git_diff_options *opts, VALUE rb_options);
diff --git a/ext/rugged/rugged_diff_hunk.c b/ext/rugged/rugged_diff_hunk.c
@@ -73,7 +73,7 @@ static VALUE rb_git_diff_hunk_each_line(VALUE self)
 		error = git_patch_get_line_in_hunk(&line, patch, hunk_idx, l);
 		if (error) break;
 
-		rb_yield(rugged_diff_line_new(self, line));
+		rb_yield(rugged_diff_line_new(line));
 	}
 	rugged_exception_check(error);
 
diff --git a/ext/rugged/rugged_diff_line.c b/ext/rugged/rugged_diff_line.c
@@ -27,12 +27,10 @@
 extern VALUE rb_cRuggedDiff;
 VALUE rb_cRuggedDiffLine;
 
-VALUE rugged_diff_line_new(VALUE owner, const git_diff_line *line)
+VALUE rugged_diff_line_new(const git_diff_line *line)
 {
 	VALUE rb_line = rb_class_new_instance(0, NULL, rb_cRuggedDiffLine), rb_line_origin;
 
-	rugged_set_owner(rb_line, owner);
-
 	switch(line->origin) {
 		case GIT_DIFF_LINE_CONTEXT:
 			rb_line_origin = CSTR2SYM("context");

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ static VALUE rb_git_diff_hunk_each_line(VALUE self)`
`73`	`73`	`error = git_patch_get_line_in_hunk(&line, patch, hunk_idx, l);`
`74`	`74`	`if (error) break;`
`75`	`75`
`76`		`- rb_yield(rugged_diff_line_new(self, line));`
	`76`	`+ rb_yield(rugged_diff_line_new(line));`
`77`	`77`	`}`
`78`	`78`	`rugged_exception_check(error);`
`79`	`79`